mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Blackwood <john.blackwood@ccur.com>
To: <linux-kernel@vger.kernel.org>
Cc: Jason Wessel <jason.wessel@windriver.com>
Subject: [PATCH] kgdb/kdb: A fix for kdb command table expansion
Date: Mon, 10 Dec 2012 15:37:22 -0600	[thread overview]
Message-ID: <50C65612.3070604@ccur.com> (raw)


When locally adding in some additional kdb commands, I stumbled
across an issue with the dynamic expansion of the kdb command table.
When the number of kdb commands exceeds the size of the statically
allocated kdb_base_commands[] array, additional space is allocated in
the kdb_register_repeat() routine.

The unused portion of the newly allocated array was not being initialized
to zero properly and this would result in segfaults when help '?' was
executed or when a search for a non-existing command would traverse the
command table beyond the end of valid command entries and then attempt
to use the non-zeroed area as actual command entries.

Signed-off-by: John Blackwood <john.blackwood@ccur.com>
Index: b/kernel/debug/kdb/kdb_main.c
===================================================================
--- a/kernel/debug/kdb/kdb_main.c
+++ b/kernel/debug/kdb/kdb_main.c
@@ -3341,7 +3341,7 @@ int kdb_register_repeat(char *cmd,
  			  (kdb_max_commands - KDB_BASE_CMD_MAX) * sizeof(*new));
  			kfree(kdb_commands);
  		}
-		memset(new + kdb_max_commands, 0,
+		memset(new + kdb_max_commands - KDB_BASE_CMD_MAX, 0,
  		       kdb_command_extend * sizeof(*new));
  		kdb_commands = new;
  		kp = kdb_commands + kdb_max_commands - KDB_BASE_CMD_MAX;

                 reply	other threads:[~2012-12-10 21:42 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50C65612.3070604@ccur.com \
    --to=john.blackwood@ccur.com \
    --cc=jason.wessel@windriver.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome