From: Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: yrl.pp-manager.tt@hitachi.com, linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>, Jiri Olsa <jolsa@redhat.com>,
Li Zefan <lizf@cn.fujitsu.com>
Subject: Re: [PATCH v2 -tip 3/4] tracing: make a snapshot feature available from userspace
Date: Mon, 17 Dec 2012 19:50:01 +0900 [thread overview]
Message-ID: <50CEF8D9.6000208@hitachi.com> (raw)
In-Reply-To: <1355504913.17101.399.camel@gandalf.local.home>
(12/15/2012 02:08 AM), Steven Rostedt wrote:
> On Fri, 2012-12-07 at 11:07 +0900, Hiraku Toyooka wrote:
>> Hi, Steven,
>>
>> (2012/11/30 23:17), Steven Rostedt wrote:
>> [snip]
>> >
>> > Actually, I would have:
>> >
>> > status\input | 0 | 1 | else |
>> > --------------+------------+------------+------------+
>> > not allocated |(do nothing)| alloc+swap | EINVAL |
>> > --------------+------------+------------+------------+
>> > allocated | free | swap | clear |
>> > --------------+------------+------------+------------+
>> >
>> > Perhaps we don't need to do the clear on swap, just let the trace
>> > continue where it left off? But in case we should swap...
>> >
>>
>> I think we don't need the clear on swap too.
>> I'll update my patches like this table.
>>
>> > There's a fast way to clear the tracer. Look at what the wakeup tracer
>> > does. We can make that generic. If you want, I can write that code up
>> > too. Hmm, maybe I'll do that, as it will speed things up for
>> > everyone :-)
>> >
>>
>
> BTW, any update on this? I really like to get this into 3.9.
>
I'm applying your review comment and rebasing now. So, I'll post the
updated patch series in a few days.
Thanks,
Hiraku Toyooka
next prev parent reply other threads:[~2012-12-17 10:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 2:56 [PATCH v2 -tip 0/4] " Hiraku Toyooka
2012-10-17 2:56 ` [PATCH v2 -tip 1/4] tracing: change tracer's integer flags to bool Hiraku Toyooka
2012-10-17 2:56 ` [PATCH v2 -tip 2/4] tracing: add a resize function for making one buffer equivalent to the other buffer Hiraku Toyooka
2012-10-17 2:56 ` [PATCH v2 -tip 3/4] tracing: make a snapshot feature available from userspace Hiraku Toyooka
2012-11-16 1:46 ` Steven Rostedt
2012-11-30 5:46 ` Hiraku Toyooka
2012-11-30 14:17 ` Steven Rostedt
2012-12-07 2:07 ` Hiraku Toyooka
2012-12-08 1:00 ` Steven Rostedt
2012-12-14 17:08 ` Steven Rostedt
2012-12-17 10:50 ` Hiraku Toyooka [this message]
2012-10-17 2:56 ` [PATCH v2 -tip 4/4] tracing: add description of snapshot to Documentation/trace/ftrace.txt Hiraku Toyooka
2012-11-16 0:16 ` [PATCH v2 -tip 0/4] tracing: make a snapshot feature available from userspace Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CEF8D9.6000208@hitachi.com \
--to=hiraku.toyooka.gu@hitachi.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome