From: Larry Finger <Larry.Finger@lwfinger.net>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
dwmw2@infradead.org, Champion Chen <champion_chen@realsil.com.cn>
Subject: Re: [PATCH] rtk_btusb: Add Bluetooth firmware
Date: Tue, 25 Dec 2012 20:24:48 -0600 [thread overview]
Message-ID: <50DA5FF0.2010300@lwfinger.net> (raw)
In-Reply-To: <1356477982.21837.93.camel@deadeye.wl.decadent.org.uk>
On 12/25/2012 05:26 PM, Ben Hutchings wrote:
> On Thu, 2012-12-20 at 20:37 -0600, Larry Finger wrote:
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>> Signed-off-by: Champion Chen <champion_chen@realsil.com.cn>
>> ---
>> WHENCE | 8 ++++++++
>> rtl_bt/rtl8723a.bin | Bin 0 -> 23772 bytes
>> 2 files changed, 8 insertions(+)
>> create mode 100644 rtl_bt/rtl8723a.bin
>>
>> diff --git a/WHENCE b/WHENCE
>> index 3b2f282..f485111 100644
>> --- a/WHENCE
>> +++ b/WHENCE
>> @@ -1811,6 +1811,14 @@ Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
>>
>> --------------------------------------------------------------------------
>>
>> +Driver: rtk_btusb - Realtek Bluetooth driver
>> +
>> +Info: Supplied by champion_chen@realsil.com.cn along with driver source code
>> +File: rtl_bt/rtl8723a.bin
>> +
>> +Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
> [...]
>
> There seem to be some serious problems with the driver that uses this.
> So, if this is not already in use with an external firmware blob, could
> you perhaps add some sort of header to the blob and have the driver make
> some sanity checks before uploading to the device?
Yes, I will add a header and the necessary checking. At that point, I will then
resubmit.
Larry
prev parent reply other threads:[~2012-12-26 2:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-21 2:37 Larry Finger
2012-12-25 23:26 ` Ben Hutchings
2012-12-26 2:24 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50DA5FF0.2010300@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=ben@decadent.org.uk \
--cc=champion_chen@realsil.com.cn \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®