Re: [PATCHv4 3/8] gpu: host1x: Add channel support

["Terje Bergström" <tbergstrom@nvidia.com>]

On 22.12.2012 06:17, Steven Rostedt wrote:
> On Fri, 2012-12-21 at 13:39 +0200, Terje Bergstrom wrote:
>> +TRACE_EVENT(host1x_cdma_begin,
>> +	TP_PROTO(const char *name),
>> +
>> +	TP_ARGS(name),
>> +
>> +	TP_STRUCT__entry(
>> +		__field(const char *, name)
>> +	),
>> +
>> +	TP_fast_assign(
>> +		__entry->name = name;
>> +	),
>> +
>> +	TP_printk("name=%s",
>> +		__entry->name)
>> +);
>> +
>> +TRACE_EVENT(host1x_cdma_end,
>> +	TP_PROTO(const char *name),
>> +
>> +	TP_ARGS(name),
>> +
>> +	TP_STRUCT__entry(
>> +		__field(const char *, name)
>> +	),
>> +
>> +	TP_fast_assign(
>> +		__entry->name = name;
>> +	),
>> +
>> +	TP_printk("name=%s",
>> +		__entry->name)
>> +);
> 
> The above two should be combined into a DECLARE_EVENT_CLASS() and
> DEFINE_EVENT()s. Saves text and data space that way.

Will do.

(...)
> If you can combine any of these others into DECLARE_EVENT_CLASS() and
> DEFINE_EVENT()s, please do.

I didn't find others with same parameters.

Thanks!

Terje