From: Tomasz Mloduchowski <q@qdot.me>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: jhovold@gmail.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: Crucible Technologies COMET Caller ID - pid added.
Date: Sun, 13 Jan 2013 22:40:20 +0100 [thread overview]
Message-ID: <50F329C4.8030308@qdot.me> (raw)
In-Reply-To: <20130113192504.GA15331@kroah.com>
On 01/13/13 20:25, Greg KH wrote:
> On Sun, Jan 13, 2013 at 07:20:27PM +0100, Tomasz Mloduchowski wrote:
>> From: Tomasz Mloduchowski <q@qdot.me>
>>
>> Simple fix to add support for Crucible Technologies COMET Caller ID
>> USB decoder - a device containing FTDI USB/Serial converter chip,
>> handling 1200bps CallerID messages decoded from the phone line -
>> adding correct USB PID is sufficient.
>>
>> Tested to apply cleanly and work flawlessly against 3.6.9, 3.7.0-rc8
>> and 3.8.0-rc3 on both amd64 and x86 arches.
>>
>> Signed-off-by: Tomasz Mloduchowski <q@qdot.me>
>> ---
>> diff -ur linux-3.8-rc3.orig/drivers/usb/serial/ftdi_sio.c
>> linux-3.8-rc3/drivers/usb/serial/ftdi_sio.c
>> --- linux-3.8-rc3.orig/drivers/usb/serial/ftdi_sio.c 2013-01-13
>> 19:41:28.000000000 +0100
>> +++ linux-3.8-rc3/drivers/usb/serial/ftdi_sio.c 2013-01-13
>> 19:49:27.239874311 +0100
>> @@ -875,6 +875,8 @@
>> { USB_DEVICE(FTDI_VID, FTDI_DISTORTEC_JTAG_LOCK_PICK_PID),
>> .driver_info = (kernel_ulong_t)&ftdi_jtag_quirk },
>> { USB_DEVICE(FTDI_VID, FTDI_LUMEL_PD12_PID) },
>> + /* Crucible Devices */
>> + { USB_DEVICE(FTDI_VID, FTDI_CT_COMET_PID) },
>> { }, /* Optional parameter entry */
>> { } /* Terminating entry */
>> };
>
> The patch is line-wrapped and all of the tabs are converted to spaces,
> both of which are keeping this patch from being able to be applied :(
>
> Care to fix your email client and resend this so that I can apply it?
>
> thanks,
>
> greg k-h
>
No problem - this should send correctly now .
Best,
Tomasz
diff -ur linux-3.8-rc3.orig/drivers/usb/serial/ftdi_sio.c linux-3.8-rc3/drivers/usb/serial/ftdi_sio.c
--- linux-3.8-rc3.orig/drivers/usb/serial/ftdi_sio.c 2013-01-13 19:41:28.000000000 +0100
+++ linux-3.8-rc3/drivers/usb/serial/ftdi_sio.c 2013-01-13 19:49:27.239874311 +0100
@@ -875,6 +875,8 @@
{ USB_DEVICE(FTDI_VID, FTDI_DISTORTEC_JTAG_LOCK_PICK_PID),
.driver_info = (kernel_ulong_t)&ftdi_jtag_quirk },
{ USB_DEVICE(FTDI_VID, FTDI_LUMEL_PD12_PID) },
+ /* Crucible Devices */
+ { USB_DEVICE(FTDI_VID, FTDI_CT_COMET_PID) },
{ }, /* Optional parameter entry */
{ } /* Terminating entry */
};
diff -ur linux-3.8-rc3.orig/drivers/usb/serial/ftdi_sio_ids.h linux-3.8-rc3/drivers/usb/serial/ftdi_sio_ids.h
--- linux-3.8-rc3.orig/drivers/usb/serial/ftdi_sio_ids.h 2013-01-13 19:41:28.000000000 +0100
+++ linux-3.8-rc3/drivers/usb/serial/ftdi_sio_ids.h 2013-01-13 19:48:24.819996641 +0100
@@ -1259,3 +1259,9 @@
* ATI command output: Cinterion MC55i
*/
#define FTDI_CINTERION_MC55I_PID 0xA951
+
+/*
+ * Product: Comet Caller ID decoder
+ * Manufacturer: Crucible Technologies
+ */
+#define FTDI_CT_COMET_PID 0x8e08
next prev parent reply other threads:[~2013-01-13 20:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-13 18:20 Tomasz Mloduchowski
2013-01-13 19:25 ` Greg KH
2013-01-13 21:40 ` Tomasz Mloduchowski [this message]
2013-01-13 21:20 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F329C4.8030308@qdot.me \
--to=q@qdot.me \
--cc=gregkh@linuxfoundation.org \
--cc=jhovold@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®