From: "Jan Beulich" <JBeulich@suse.com>
To: "Borislav Petkov" <bp@alien8.de>,
"Andre Przywara" <andre@andrep.de>,
"Stefan Bader" <stefan.bader@canonical.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
"Matthew Garrett" <mjg@redhat.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] kernel 3.7+ cpufreq regression on AMD system running as dom0
Date: Mon, 14 Jan 2013 16:55:36 +0000 [thread overview]
Message-ID: <50F4469802000078000B57EB@nat28.tlf.novell.com> (raw)
In-Reply-To: <20130114163445.GA4867@liondog.tnic>
>>> On 14.01.13 at 17:34, Borislav Petkov <bp@alien8.de> wrote:
> On Mon, Jan 14, 2013 at 04:58:54PM +0100, Stefan Bader wrote:
>> --- a/drivers/acpi/processor_perflib.c
>> +++ b/drivers/acpi/processor_perflib.c
>> @@ -340,6 +340,9 @@ static void amd_fixup_frequency(struct acpi_processor_px
> *px
>> if ((boot_cpu_data.x86 == 0x10 && boot_cpu_data.x86_model < 10)
>> || boot_cpu_data.x86 == 0x11) {
>> rdmsr(MSR_AMD_PSTATE_DEF_BASE + index, lo, hi);
>> + /* Bit 63 indicates whether contents are valid */
>> + if (!(hi & 0x8000000))
>> + return;
>
> I don't think that's the right change - this is fixing baremetal so that
> it works on xen. And besides, this code was in powernow-k8 before so I'm
> wondering why did it work then.
Because the driver doesn't get loaded in that case?
Jan
next prev parent reply other threads:[~2013-01-14 16:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 15:58 Stefan Bader
2013-01-14 16:34 ` Borislav Petkov
2013-01-14 16:55 ` Jan Beulich [this message]
2013-01-14 17:08 ` [Xen-devel] " Stefan Bader
2013-01-14 17:40 ` André Przywara
2013-01-15 17:53 ` Konrad Rzeszutek Wilk
2013-01-15 18:18 ` Borislav Petkov
2013-01-18 19:00 ` Konrad Rzeszutek Wilk
2013-01-18 19:38 ` [Xen-devel] " Boris Ostrovsky
2013-01-18 20:03 ` Borislav Petkov
2013-01-18 22:00 ` Konrad Rzeszutek Wilk
2013-01-21 12:22 ` Stefan Bader
2013-01-21 12:42 ` Borislav Petkov
2013-01-21 12:53 ` Rafael J. Wysocki
2013-01-21 13:08 ` Borislav Petkov
2013-01-21 13:11 ` Stefan Bader
2013-01-21 15:03 ` Stefan Bader
2013-01-21 15:31 ` Borislav Petkov
2013-01-22 13:54 ` Rafael J. Wysocki
2013-01-22 0:01 ` [Xen-devel] " Boris Ostrovsky
2013-01-16 10:26 ` Jan Beulich
2013-01-16 14:34 ` Stefan Bader
2013-01-15 13:04 ` Matt Wilson
2013-01-15 17:59 ` [Xen-devel] " Matt Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F4469802000078000B57EB@nat28.tlf.novell.com \
--to=jbeulich@suse.com \
--cc=andre@andrep.de \
--cc=bp@alien8.de \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=rjw@sisk.pl \
--cc=stefan.bader@canonical.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®