From: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 3/4] dt-bindings: sound: qcom,q6apm-dai: add memory-region and relax iommus
Date: Wed, 23 Sep 2026 21:52:33 +0530 [thread overview]
Message-ID: <50b1dabd-4e5f-49a6-b682-1059681b00a0@oss.qualcomm.com> (raw)
In-Reply-To: <0d2a8e7b-6a7c-4cb8-a6e4-98a7a5615764@kernel.org>
On 9/23/2026 5:27 PM, Krzysztof Kozlowski wrote:
>> diff --git a/Documentation/devicetree/bindings/sound/qcom,q6apm-dai.yaml b/Documentation/devicetree/bindings/sound/qcom,q6apm-dai.yaml
>> index 9e5b30d9c6e6..7d0415f2463a 100644
>> --- a/Documentation/devicetree/bindings/sound/qcom,q6apm-dai.yaml
>> +++ b/Documentation/devicetree/bindings/sound/qcom,q6apm-dai.yaml
>> @@ -20,9 +20,19 @@ properties:
>> minItems: 1
>> maxItems: 2
>>
>> + memory-region:
>> + minItems: 1
>> + maxItems: 2
>> + items:
>> + - description:
>> + Control-path buffer (audio_heap_mem) for platforms where the DSP
>> + runs in a stage-2 protected context (e.g. modem-DSP).
>> + - description:
>> + Data-path buffer pool from which per-stream DMA buffers are
>> + allocated.
>> +
>> required:
>> - compatible
>> - - iommus
> I imagine you either have iommus or memory-region, no? IOW,
> oneOf:
> - required:
> - iommus
> - required:
> - memory-region
> ?
Yes, that matches the intended split.
For existing ADSP/SMMU platforms, q6apm-dais uses iommus. For the
mDSP/VMID path, the DSP cannot access normal SMMU-backed system
memory,so the buffers have to come from reserved-memory carveouts which
the driver SCM-assigns to the fixed VMIDs.
I will add the oneOf constraint in v6 to require either iommus or
memory-region. VMIDs remain internal to the driver and are not described
in DT.
Thanks
Ajay Kumar Nandam
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2026-09-23 16:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 19:08 [PATCH v5 0/4] ASoC: qcom: enable audio on stage-2 protected DSPs (mDSP) Ajay Kumar Nandam
2026-09-21 19:08 ` [PATCH v5 1/4] ASoC: qcom: q6apm: clear g_apm on driver removal Ajay Kumar Nandam
2026-09-21 19:08 ` [PATCH v5 2/4] ASoC: qcom: qdsp6: generalize GPR service domain Ajay Kumar Nandam
2026-09-21 19:08 ` [PATCH v5 3/4] dt-bindings: sound: qcom,q6apm-dai: add memory-region and relax iommus Ajay Kumar Nandam
2026-09-22 12:21 ` Mark Brown
2026-09-23 11:08 ` Ajay Kumar Nandam
2026-09-22 12:46 ` Rob Herring (Arm)
2026-09-23 11:12 ` Ajay Kumar Nandam
2026-09-23 11:57 ` Krzysztof Kozlowski
2026-09-23 16:22 ` Ajay Kumar Nandam [this message]
2026-09-21 19:08 ` [PATCH v5 4/4] ASoC: qcom: q6apm-dai: add SCM buffer assignment for mDSP platforms Ajay Kumar Nandam
2026-09-22 12:30 ` Mark Brown
2026-09-23 11:20 ` Ajay Kumar Nandam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50b1dabd-4e5f-49a6-b682-1059681b00a0@oss.qualcomm.com \
--to=ajay.nandam@oss.qualcomm.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.dev \
--cc=robh@kernel.org \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®