From: Tuo Li <islituo@gmail.com>
To: njavali@marvell.com, mrangankar@marvell.com,
GR-QLogic-Storage-Upstream@marvell.com, jejb@linux.ibm.com,
martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
"baijiaju1990@gmail.com" <baijiaju1990@gmail.com>
Subject: [BUG] scsi: qla4xxx: possible double lock in qla4_82xx_wr_32()
Date: Wed, 11 Aug 2021 21:44:29 +0800 [thread overview]
Message-ID: <50b8ad40-b272-d601-889e-9ef336bf9170@gmail.com> (raw)
Hello,
Our static analysis tool finds a possible double lock in ql4_nx.c in
Linux 5.14.0-rc3:
ha->hw_lock is first locked in:
418: write_lock_irqsave(&ha->hw_lock, flags);
And then the function qla4_82xx_crb_win_lock() is called:
419: qla4_82xx_crb_win_lock(ha);
In this function, the function qla4_82xx_rd_32() is called:
389: done = qla4_82xx_rd_32(ha, QLA82XX_PCIE_REG(PCIE_SEM7_LOCK));
In this function, ha->hw_lock is locked again:
442: write_lock_irqsave(&ha->hw_lock, flags);
I am not quite sure whether this possible double lock is real and how to
fix it if it is real.
Any feedback would be appreciated, thanks!
Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Best wishes,
Tuo Li
reply other threads:[~2021-08-11 13:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50b8ad40-b272-d601-889e-9ef336bf9170@gmail.com \
--to=islituo@gmail.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=baijiaju1990@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mrangankar@marvell.com \
--cc=njavali@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®