From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0898C83F11 for ; Sat, 26 Aug 2023 12:02:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232725AbjHZMCR (ORCPT ); Sat, 26 Aug 2023 08:02:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232571AbjHZMBz (ORCPT ); Sat, 26 Aug 2023 08:01:55 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD5502106 for ; Sat, 26 Aug 2023 05:01:52 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-400a087b0bfso15573825e9.2 for ; Sat, 26 Aug 2023 05:01:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693051311; x=1693656111; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RO8Yyz2oHTR16ECZ9Rr/IoSLhSOOtJfBRk2Q+FHvz2I=; b=UNgdJXuoBfk2mYXCWlsSN5/r0eXptoM2PMRb1lUyw92Ix1ueZgrbEQHPWckg0BW6ZT zCbNu30hdb70ynY2kz95DF9fX7Ly3O7fZLcEtUkj18rnQcqa41u5YXBYezH9SNjWviAF DFA65k2ni2+XrwK/GUAOKk/YJcu93EugffqezHYqsPC41e8FkJRaZ1KUn1lmrcudkxKi lO78+v3s+XsjMehk3mHl9yCRVrg8TRT27xSilthVNlQ7hOYiH8dMq3EI2lhtFlSn3+fv /N27dFaMmSoL52GTo77dcoTeoT9b8KtJL7eelpsOlkh/Z7+AzeI3XHUGhI6ckNsgAadV QLYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693051311; x=1693656111; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RO8Yyz2oHTR16ECZ9Rr/IoSLhSOOtJfBRk2Q+FHvz2I=; b=L1IeAZqGG9eYYXHiHFHEELnbWgi5Q8DUWL6mHpHapRfm/JbGy2VIO+oyuawxzWnxsj 5d10kFkh1MM4GKlocnSTKUMppZhOEMqxsWP+Y2EGlZlCzbyuc5m/6ctYIrlODVynLeFL bP8mk7GMbMa4iG78fZ5xHKKyB8Nc2LbaDMXHnFfd5phWtDJHgqcyjHGx+w7HWeUewrRS cCK0OCUAmO2FG8XfS1U5WLdocuG6iJxnbilR/6EKkSkdUwgCr/9uFmQm9sUfYF93uLlF T/RcidBd9n44BsEHQiYF1MWgPNRX8zFedKHjlRh940yDJ0r5T1Zh76qzokt5ByneUMJ+ OkEg== X-Gm-Message-State: AOJu0Yxjj3teLPBqvu4a4OO4vN5wWJ/QuGOGeGHYSLO4h5U7YtC92j0V jBnRzRO0SCgv5VtKO2wUNrd42g== X-Google-Smtp-Source: AGHT+IGfg0YU6vo3D5Gw6EI77NS2wTCFEgGf6amHUaQ6pN1e8MMnuBSRUFaaQTjlcDA6wKnEA9S4nw== X-Received: by 2002:a05:600c:ad2:b0:401:aa8f:7562 with SMTP id c18-20020a05600c0ad200b00401aa8f7562mr5271832wmr.11.1693051311340; Sat, 26 Aug 2023 05:01:51 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id x7-20020a1c7c07000000b003ffca80edb8sm4854067wmc.15.2023.08.26.05.01.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Aug 2023 05:01:50 -0700 (PDT) Message-ID: <50b9d9f5-0433-2d7d-71af-10f4b3b8e448@linaro.org> Date: Sat, 26 Aug 2023 13:01:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 09/15] media: qcom: camss: Improve error printout on icc_get fail Content-Language: en-US To: Konrad Dybcio , rfoss@kernel.org, todor.too@gmail.com, agross@kernel.org, andersson@kernel.org, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com, andrey.konovalov@linaro.org Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230823104444.1954663-1-bryan.odonoghue@linaro.org> <20230823104444.1954663-10-bryan.odonoghue@linaro.org> <92e864cd-b98f-45d1-a46e-e5bfc52b4b08@linaro.org> From: Bryan O'Donoghue In-Reply-To: <92e864cd-b98f-45d1-a46e-e5bfc52b4b08@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/08/2023 11:05, Konrad Dybcio wrote: > On 23.08.2023 12:44, Bryan O'Donoghue wrote: >> If icc_get() fails print the name of the failing path. >> >> Signed-off-by: Bryan O'Donoghue >> --- > Aren't the return messages propagated from > > * of_icc_get() > |_ of_icc_get_by_index() > > enough here? > > Perhaps we should use dev_err_probe in camss too > > Konrad IDK, I will check