From: Chen Yu <yu.c.chen@intel.com>
To: tony.luck@intel.com, reinette.chatre@intel.com
Cc: tglx@kernel.org, bp@alien8.de, mingo@redhat.com,
dave.hansen@linux.intel.com, hpa@zytor.com, fenghuay@nvidia.com,
babu.moger@amd.com, chen.yu@linux.dev, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v7 8/9] x86/resctrl: Introduce erdt_cpu_has() and erdt_support()
Date: Sat, 29 Aug 2026 14:02:46 +0800 [thread overview]
Message-ID: <50bc766fe30604a09eac2ac0fc3ad0bef525551d.1787976868.git.yu.c.chen@intel.com> (raw)
In-Reply-To: <cover.1787976868.git.yu.c.chen@intel.com>
Introduce erdt_cpu_has() to verify if a specific RDT feature is backed by an
ERDT table. erdt_cpu_has() is derived from rdt_cpu_has(), which not only
considers firmware (ERDT table and its sub-tables) support for a feature, but
also considers userspace input like "rdt=!cmt". Similar to rdt_cpu_has(),
erdt_cpu_has() expects an x86 feature flag as parameter.
Introduce erdt_support() as a helper called by erdt_cpu_has() to check whether
the ERDT firmware supports a given feature.
erdt_support() deliberately claims no feature yet and returns false. A
feature may only be reported as ERDT backed once the low level accessors
that read its monitoring data via MMIO exist, otherwise callers would
take the ERDT path and find no implementation behind it. Features
should be added to erdt_support() as their MMIO implementations are
introduced.
Signed-off-by: Chen Yu <yu.c.chen@intel.com>
Tested-by: Hongyu Ning <hongyu.ning@linux.intel.com>
---
v6->v7:
Reword "an event" to "a feature", since the check is not
monitoring-only. (Reinette Chatre)
Reword "are added" to "should be added". (Reinette Chatre)
Remove the duplicate erdt_cpu_has() declaration, keeping only the one
in asm/resctrl.h required by the inline resctrl_arch_round_mon_val().
(Reinette Chatre)
---
arch/x86/include/asm/resctrl.h | 1 +
arch/x86/kernel/cpu/resctrl/core.c | 23 +++++++++++++++++++++++
arch/x86/kernel/cpu/resctrl/erdt.c | 5 +++++
arch/x86/kernel/cpu/resctrl/internal.h | 1 +
4 files changed, 30 insertions(+)
diff --git a/arch/x86/include/asm/resctrl.h b/arch/x86/include/asm/resctrl.h
index 4225a518fada..a8dfaca5c6f8 100644
--- a/arch/x86/include/asm/resctrl.h
+++ b/arch/x86/include/asm/resctrl.h
@@ -49,6 +49,7 @@ DECLARE_STATIC_KEY_FALSE(rdt_enable_key);
DECLARE_STATIC_KEY_FALSE(rdt_alloc_enable_key);
DECLARE_STATIC_KEY_FALSE(rdt_mon_enable_key);
+bool erdt_cpu_has(int flag);
unsigned int erdt_get_scale(void);
static inline bool resctrl_arch_alloc_capable(void)
diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
index 51185a8770bf..2db9c71bf1f0 100644
--- a/arch/x86/kernel/cpu/resctrl/core.c
+++ b/arch/x86/kernel/cpu/resctrl/core.c
@@ -895,6 +895,29 @@ bool rdt_cpu_has(int flag)
return ret;
}
+bool erdt_cpu_has(int flag)
+{
+ struct rdt_options *o;
+ bool ret;
+
+ ret = erdt_support(flag);
+
+ if (!ret)
+ return ret;
+
+ for (o = rdt_options; o < &rdt_options[NUM_RDT_OPTIONS]; o++) {
+ if (flag == o->flag) {
+ if (o->force_off)
+ ret = false;
+ if (o->force_on)
+ ret = true;
+ break;
+ }
+ }
+
+ return ret;
+}
+
bool resctrl_arch_is_evt_configurable(enum resctrl_event_id evt)
{
if (!rdt_cpu_has(X86_FEATURE_BMEC))
diff --git a/arch/x86/kernel/cpu/resctrl/erdt.c b/arch/x86/kernel/cpu/resctrl/erdt.c
index 1c477e35d044..e6eba4067348 100644
--- a/arch/x86/kernel/cpu/resctrl/erdt.c
+++ b/arch/x86/kernel/cpu/resctrl/erdt.c
@@ -48,6 +48,11 @@ static unsigned int erdt_max_rmid;
*/
static unsigned int erdt_scale;
+bool erdt_support(int flag)
+{
+ return false;
+}
+
unsigned int erdt_get_max_rmid(void)
{
return erdt_max_rmid;
diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
index 160174c25792..bb7a902b5b9d 100644
--- a/arch/x86/kernel/cpu/resctrl/internal.h
+++ b/arch/x86/kernel/cpu/resctrl/internal.h
@@ -289,6 +289,7 @@ static inline void intel_aet_mon_domain_setup(int cpu, int id, struct rdt_resour
static inline bool intel_handle_aet_option(bool force_off, char *tok) { return false; }
#endif
+bool erdt_support(int flag);
unsigned int erdt_get_max_rmid(void);
int erdt_init(void);
void erdt_exit(void);
--
2.25.1
next prev parent reply other threads:[~2026-08-29 6:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-29 5:55 [PATCH v7 0/9] Introduce MMIO-based CMT access for Enhanced RDT Chen Yu
2026-08-29 5:57 ` [PATCH v7 1/9] x86/topology: Export topo_lookup_cpuid() for resctrl use Chen Yu
2026-08-29 5:57 ` [PATCH v7 2/9] x86/resctrl: Require 64-bit x86 for resctrl support Chen Yu
2026-08-29 5:57 ` [PATCH v7 3/9] x86/resctrl: Parse ACPI ERDT table and save CACD cpumask for RMDD domains Chen Yu
2026-08-29 6:00 ` [PATCH v7 4/9] x86/resctrl: Attach ACPI ERDT information to L3 mon domain on CPU online Chen Yu
2026-08-29 6:01 ` [PATCH v7 5/9] x86/resctrl: Parse ACPI CMRC table Chen Yu
2026-08-29 6:02 ` [PATCH v7 6/9] x86/resctrl: Refactor the monitor read function Chen Yu
2026-08-29 6:02 ` [PATCH v7 7/9] fs/resctrl: Do not invoke smp_processor_id() in preemptible context Chen Yu
2026-08-29 6:02 ` Chen Yu [this message]
2026-08-29 6:02 ` [PATCH v7 9/9] x86/resctrl: Add MMIO-based LLC occupancy monitoring support Chen Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50bc766fe30604a09eac2ac0fc3ad0bef525551d.1787976868.git.yu.c.chen@intel.com \
--to=yu.c.chen@intel.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=chen.yu@linux.dev \
--cc=dave.hansen@linux.intel.com \
--cc=fenghuay@nvidia.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=reinette.chatre@intel.com \
--cc=tglx@kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®