From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Komal Bajaj <quic_kbajaj@quicinc.com>,
agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
srinivas.kandagatla@linaro.org, bryan.odonoghue@linaro.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 4/6] soc: qcom: Add LLCC support for multi channel DDR
Date: Wed, 30 Aug 2023 14:33:08 +0200 [thread overview]
Message-ID: <50c2777f-de2e-4f57-9a94-ae25c8ee759a@linaro.org> (raw)
In-Reply-To: <cec9318c-9a70-4392-89b7-048d30b7b790@linaro.org>
On 30.08.2023 14:32, Konrad Dybcio wrote:
> On 30.08.2023 12:56, Komal Bajaj wrote:
>> Add LLCC support for multi channel DDR configuration
>> based on a feature register.
>>
>> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
>> ---
> [...]
>
> global pointer to a error code to avoid referencing it */
>> @@ -1031,6 +1050,7 @@ static int qcom_llcc_probe(struct platform_device *pdev)
>> const struct qcom_llcc_config *cfg;
>> const struct llcc_slice_config *llcc_cfg;
>> u32 sz;
>> + u8 cfg_index;
>> u32 version;
>> struct regmap *regmap;
>>
>> @@ -1052,7 +1072,10 @@ static int qcom_llcc_probe(struct platform_device *pdev)
>> ret = -EINVAL;
>> goto err;
>> }
>> - cfg = &cfgs->llcc_config[0];
> This is unnecessary, get_cfg_index returns 0 when no nvmem cell is
> present.
Sorry this is a minus and not a plus
Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
next prev parent reply other threads:[~2023-08-30 18:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 10:56 [PATCH v8 0/6] soc: qcom: llcc: Add support for QDU1000/QRU1000 Komal Bajaj
2023-08-30 10:56 ` [PATCH v8 1/6] dt-bindings: cache: qcom,llcc: Add LLCC compatible " Komal Bajaj
2023-08-30 10:56 ` [PATCH v8 2/6] soc: qcom: llcc: Refactor llcc driver to support multiple configuration Komal Bajaj
2023-08-30 12:35 ` Konrad Dybcio
2023-08-31 13:31 ` Mukesh Ojha
2023-08-30 10:56 ` [PATCH v8 3/6] nvmem: core: Add stub for nvmem_cell_read_u8 Komal Bajaj
2023-08-31 13:43 ` Mukesh Ojha
2023-09-13 19:27 ` Bjorn Andersson
2023-09-20 7:24 ` Srinivas Kandagatla
2023-08-30 10:56 ` [PATCH v8 4/6] soc: qcom: Add LLCC support for multi channel DDR Komal Bajaj
2023-08-30 12:32 ` Konrad Dybcio
2023-08-30 12:33 ` Konrad Dybcio [this message]
2023-08-31 13:46 ` Mukesh Ojha
2023-08-30 10:56 ` [PATCH v8 5/6] soc: qcom: llcc: Updating the macro name Komal Bajaj
2023-08-30 10:56 ` [PATCH v8 6/6] soc: qcom: llcc: Add QDU1000 and QRU1000 LLCC support Komal Bajaj
2023-08-30 12:33 ` Konrad Dybcio
2023-08-31 13:42 ` Mukesh Ojha
2023-09-20 17:14 ` [PATCH v8 0/6] soc: qcom: llcc: Add support for QDU1000/QRU1000 Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50c2777f-de2e-4f57-9a94-ae25c8ee759a@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_kbajaj@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®