From: Zhang Yi <yi.zhang@huaweicloud.com>
To: Zhu Jia <zhujia.zj@bytedance.com>,
tytso@mit.edu, adilger.kernel@dilger.ca
Cc: libaokun@linux.alibaba.com, jack@suse.cz, ojaswin@linux.ibm.com,
ritesh.list@gmail.com, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Zhang Yi <yizhang089@gmail.com>
Subject: Re: [PATCH v2] ext4: cancel dirty accounting for folios without buffers
Date: Sat, 27 Jun 2026 11:47:22 +0800 [thread overview]
Message-ID: <50c685dd-077f-4352-a8a1-6a0e23daeb06@huaweicloud.com> (raw)
In-Reply-To: <20260626100740.52455-1-zhujia.zj@bytedance.com>
On 6/26/2026 6:07 PM, Zhu Jia wrote:
> Since commit cc5095747edf ("ext4: don't BUG if someone dirty pages
> without asking ext4 first"), mpage_prepare_extent_to_map() handles dirty
> folios without buffer heads by warning, clearing PG_dirty, and skipping
> them. ext4 cannot write these folios because there are no buffer heads to
> map and submit.
>
> That recovery leaves dirty accounting behind: folio_clear_dirty() clears
> PG_dirty but does not undo the accounting charged when the folio was
> dirtied. We have seen this in production as Dirty/nr_dirty staying high
> while Writeback/nr_writeback and device write IO stayed near zero, with
> many writer tasks blocked in balance_dirty_pages() throttling. Thus the
> warning-and-skip recovery can still become a dirty-throttle DoS.
>
> Use folio_cancel_dirty() so dropping PG_dirty also cancels the dirty
> accounting. Then cycle the folio through writeback state so the generic
> writeback helpers update the xarray DIRTY/TOWRITE tags.
>
> Fixes: cc5095747edf ("ext4: don't BUG if someone dirty pages without asking ext4 first")
> Cc: stable@vger.kernel.org
> Suggested-by: Zhang Yi <yizhang089@gmail.com>
> Reviewed-by: Jan Kara <jack@suse.cz>
> Signed-off-by: Zhu Jia <zhujia.zj@bytedance.com>
Looks good to me.
Reviewed-by: Zhang Yi <yi.zhang@huawei.com>
> ---
> Changes since v1:
> - After folio_cancel_dirty(), cycle the folio through writeback state so
> generic writeback helpers update PAGECACHE_TAG_DIRTY/TOWRITE, as
> suggested by Yi and Jan.
>
> fs/ext4/inode.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index c2c2d6ac7f3d1..4c25dcd47fb15 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -2715,7 +2715,15 @@ static int mpage_prepare_extent_to_map(struct mpage_da_data *mpd)
> */
> if (!folio_buffers(folio)) {
> ext4_warning_inode(mpd->inode, "page %lu does not have buffers attached", folio->index);
> - folio_clear_dirty(folio);
> + /*
> + * folio_cancel_dirty() pairs the dropped dirty
> + * state with dirty accounting. Cycle through
> + * writeback state so the generic writeback
> + * helpers update the xarray tags.
> + */
> + folio_cancel_dirty(folio);
> + folio_start_writeback(folio);
> + folio_end_writeback(folio);
> folio_unlock(folio);
> continue;
> }
next prev parent reply other threads:[~2026-06-27 3:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-26 10:07 Zhu Jia
2026-06-27 3:47 ` Zhang Yi [this message]
2026-08-12 10:05 ` Zhu Jia
2026-10-09 7:23 ` Jia Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50c685dd-077f-4352-a8a1-6a0e23daeb06@huaweicloud.com \
--to=yi.zhang@huaweicloud.com \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=libaokun@linux.alibaba.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=yizhang089@gmail.com \
--cc=zhujia.zj@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®