Re: [EXT] Re: [PATCH v4 2/4] media: ox05b1s: Add omnivision OX05B1S raw sensor driver

[Mirela Rabulea <mirela.rabulea@nxp.com>]

Hi Sakari,

On 7/9/25 02:43, Sakari Ailus wrote:
> Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button
>
>
> Hi Mirela,
>
> On Tue, Jul 08, 2025 at 08:09:25PM +0300, Mirela Rabulea wrote:
>> Hi Sakari & all,
>>
>> On 6/29/25 11:30, Sakari Ailus wrote:
>>> Caution: This is an external email. Please take care when clicking links
>>> or opening attachments. When in doubt, report the message using the
>>> 'Report this email' button
>>>
>>>
>>> Hi Mirela,
>>>
>>> On 3/5/25 11:43, Mirela Rabulea wrote:
>>>> +struct ox05b1s_reg {
>>>> +     u32 addr;
>>>> +     u32 data;
>>>> +};
>>> Could you use struct reg_sequence instead, please?
>> Yes, sure, thanks for the hint.
>>
>> Any other suggestions, anyone, before I send the next version?
> Do you intend to align this with the common raw sensor model? It may still
> take a while until we get those patches merged though, but the upside would
> be there's on concern of backwards compatibility. We should discuss how to
> implement HDR with that actually (Laurent is cc'd).

Yes, I will align with the common raw sensor model. By that I mean I 
will use generic Y formats and the CFA pattern control (already switched 
to Y formats in this  v4, did not experiment yet the new control) and I 
can add streams and routes as soon as internal pads are merged, we 
already experimented with that both for os08a20 HDR and for ox05b1s 
context switching, both using multiple captures on 2 virtual channels. 
I'm also planning to send an RFC for standard controls as arrays for 
exposure and gains, as discussed during the media summit, that's 
currently under internal review.

I'm open for discussions.

For this driver, up until this version, the HDR support is minimal, it 
is just enabled/disabled and tied to the existing control 
V4L2_CID_HDR_SENSOR_MODE, and still only 1 VC is exposed. When we will 
have internal pads and streams and routes, we can toggle the HDR control 
depending on what routes are enabled, already experimented with that 
(the HDR control can in this case be optional).

I saw you sent v10 for generic line based metadata and internal pads, I 
started looking into it, large patch-set ;)

Regards,

Mirela

>
> --
> Regards,
>
> Sakari Ailus