From: Meelis Roos <mroos@linux.ee>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org
Cc: Zhenzhong Duan <zhenzhong.duan@oracle.com>,
Meelis Roos <mroos@linux.ee>, "H. Peter Anvin" <hpa@zytor.com>,
Borislav Petkov <bp@alien8.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86/build: fix compiler support check for CONFIG_RETPOLINE
Date: Wed, 5 Dec 2018 08:59:58 +0200 [thread overview]
Message-ID: <50d52efb-622e-e5fc-558e-d1a08de902e9@linux.ee> (raw)
In-Reply-To: <1543991239-18476-1-git-send-email-yamada.masahiro@socionext.com>
05.12.18 08:27 Masahiro Yamada kirjutas:
> The easiest fix is to move this check to the "archprepare" like commit
> 829fe4aa9ac1 ("x86: Allow generating user-space headers without a
> compiler") did.
>
> Link: https://lkml.org/lkml/2018/12/4/206
> Fixes: 4cd24de3a098 ("x86/retpoline: Make CONFIG_RETPOLINE depend on compiler support")
> Reported-by: Meelis Roos <mroos@linux.ee>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> Changes in v2:
> - Revive ifdef CONFIG_RETPOLINE surrounding the KBUILD_CFLAGS addition
> - Rephase the commit log a bit, hoping the cause of the issue will be clearer
Works for me - first it did
scripts/kconfig/conf --syncconfig Kconfig
and then started compiling. The #define is gone from include/linux.
Thank you!
--
Meelis Roos <mroos@linux.ee>
next prev parent reply other threads:[~2018-12-05 7:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 6:27 Masahiro Yamada
2018-12-05 6:59 ` Meelis Roos [this message]
2018-12-05 7:10 ` Zhenzhong Duan
2018-12-18 13:20 ` Gi-Oh Kim
2018-12-05 7:45 ` [tip:x86/urgent] x86/build: Fix " tip-bot for Masahiro Yamada
2018-12-05 7:48 ` tip-bot for Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50d52efb-622e-e5fc-558e-d1a08de902e9@linux.ee \
--to=mroos@linux.ee \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
--cc=zhenzhong.duan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®