From: Michal Wilczynski <m.wilczynski@samsung.com>
To: sboyd@kernel.org, Drew Fustini <drew@pdp7.com>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
Rob Herring <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
Guo Ren <guoren@kernel.org>, Fu Wei <wefu@redhat.com>,
"paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
"palmer@dabbelt.com" <palmer@dabbelt.com>,
"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
alex@ghiti.fr, "jszhang@kernel.org" <jszhang@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v7 0/3] Add T-HEAD TH1520 VO clock support for LicheePi 4A GPU enablement
Date: Tue, 22 Apr 2025 16:54:20 +0200 [thread overview]
Message-ID: <50da445f-d6f9-407d-b25d-5b9c7ccf867c@samsung.com> (raw)
In-Reply-To: <20250403094425.876981-1-m.wilczynski@samsung.com>
On 4/3/25 11:44, Michal Wilczynski wrote:
> This is a subset of a larger patch series enabling the Imagination BXM-4-64 GPU
> on the LicheePi 4A board, which is powered by the T-HEAD TH1520 SoC. While the
> full series includes power-domain, reset, and firmware changes, this part
> focuses solely on the clock subsystem needed for the GPU and other VO (video
> output) blocks. By merging these clock patches independently, we prepare the
> groundwork for future GPU integration via the `drm/imagination` driver.
>
> The T-HEAD TH1520 SoC features multiple clock controllers. Initially, only the
> AP clock controller was supported upstream. The patches below add support for
> the VO (video output) clock controller, which manages GPU-related gates, HDMI,
> and other multimedia clocks.
>
> Bigger series cover letter:
> https://lore.kernel.org/all/20250219140239.1378758-1-m.wilczynski@samsung.com/
>
> v7:
> - remove commits 3,4 from the patch series, those would handle empty MEM clock
> stub, and reset management. It's not necessary anymore, as this would be
> implemented in power-domain driver
> - added the device tree patch at the end for the SoC maintainers to take after
> the other patches get OK-ed
> - added Acked-by, from Connor for the dt-binding patch
> - re-added Reviewed-by from Krzysztof, as the dt-binding patch is the same as
> for the v5
>
> v6:
> - squashed the "dt-bindings: clock: thead: Add GPU clkgen reset property"
> with the "dt-bindings: clock: thead: Add TH1520 VO clock controller". As
> a result, also removed the Reviewed-by from Krzysztof, since the new
> resets property has been introduced, which is mandatory in the VO
> case
>
> v5:
> - introduced a new macro CCU_GATE_CLK_OPS, which allows providing custom clk_ops.
> In the case of the 'MEM' clock, it provides empty clk_nops. Later, this clock
> is provided to the GPU node, thereby avoiding any ABI breakage
> - used the CCU_GATE_CLK_OPS macro to implement a workaround for de-asserting
> the clkgen reset only after both core and sys clocks are enabled. This
> sequence is required to properly initialize the GPU
>
> v4:
> - enhanced documentation for new Video Output (VO) clock inputs in device tree
> bindings
>
> v3:
> - reworked driver to support multiple clock controllers through .compatible
> and .data instead of using multiple address spaces in dt-binding. This change
> allows to re-use the driver code for multiple clock controllers
>
> v2:
> - removed AP_SUBSYS clock refactoring commits (1-6):
> - instead of refactoring, I opted to extend the current driver and its
> associated device tree node to include support for a second address space.
> - resolved all checkpatch issues using --strict, except for the call to
> devm_clk_hw_register_gate_parent_data(). The current implementation remains
> preferable in this context, and clang-format aligns with this choice
>
> Michal Wilczynski (3):
> dt-bindings: clock: thead: Add TH1520 VO clock controller
> clk: thead: Add clock support for VO subsystem in T-HEAD TH1520 SoC
> riscv: dts: thead: Add device tree VO clock controller
>
> .../bindings/clock/thead,th1520-clk-ap.yaml | 17 +-
> arch/riscv/boot/dts/thead/th1520.dtsi | 7 +
> drivers/clk/thead/clk-th1520-ap.c | 196 +++++++++++++++---
> .../dt-bindings/clock/thead,th1520-clk-ap.h | 34 +++
> 4 files changed, 223 insertions(+), 31 deletions(-)
>
Hi Stephen, I think Drew is already collecting DT commits for the next
merge window. Do you think the patches 1-2 will make it for the 6.16
release ?
Best regards,
--
Michal Wilczynski <m.wilczynski@samsung.com>
prev parent reply other threads:[~2025-04-22 14:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250403094430eucas1p21515d7f693708fc2ad0cd399cb0b81aa@eucas1p2.samsung.com>
2025-04-03 9:44 ` Michal Wilczynski
[not found] ` <CGME20250403094431eucas1p21412dff1c24aae077fdfeef08e0f802b@eucas1p2.samsung.com>
2025-04-03 9:44 ` [PATCH v7 1/3] dt-bindings: clock: thead: Add TH1520 VO clock controller Michal Wilczynski
2025-04-06 19:59 ` Drew Fustini
[not found] ` <CGME20250403094432eucas1p112aada697802092266bc36ef863f4299@eucas1p1.samsung.com>
2025-04-03 9:44 ` [PATCH v7 2/3] clk: thead: Add clock support for VO subsystem in T-HEAD TH1520 SoC Michal Wilczynski
2025-04-05 0:40 ` Drew Fustini
2025-04-07 16:16 ` Michal Wilczynski
2025-04-07 18:20 ` Drew Fustini
[not found] ` <CGME20250403094433eucas1p2da03e00ef674c1f5aa8d41f2a7371319@eucas1p2.samsung.com>
2025-04-03 9:44 ` [PATCH v7 3/3] riscv: dts: thead: Add device tree VO clock controller Michal Wilczynski
2025-04-04 23:16 ` Drew Fustini
2025-04-07 15:30 ` Michal Wilczynski
2025-04-07 18:21 ` Drew Fustini
2025-04-29 22:29 ` Stephen Boyd
2025-04-30 7:52 ` Michal Wilczynski
2025-05-02 17:35 ` Drew Fustini
2025-05-06 21:30 ` Stephen Boyd
2025-05-07 10:04 ` Michal Wilczynski
2025-05-08 18:23 ` Drew Fustini
2025-04-22 14:54 ` Michal Wilczynski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50da445f-d6f9-407d-b25d-5b9c7ccf867c@samsung.com \
--to=m.wilczynski@samsung.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=drew@pdp7.com \
--cc=guoren@kernel.org \
--cc=jszhang@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=m.szyprowski@samsung.com \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=wefu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®