From: Xiubo Li <xiubli@redhat.com>
To: liujian <liujian56@huawei.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] driver: uio: fix possible memory leak in uio_open
Date: Wed, 2 Jan 2019 14:36:55 +0800 [thread overview]
Message-ID: <50ee4818-a154-5ea7-20f8-3c0f0859f4fa@redhat.com> (raw)
In-Reply-To: <1546446416-40831-1-git-send-email-liujian56@huawei.com>
On 2019/1/3 0:26, liujian wrote:
> Fixes: 57c5f4df0a5a ("uio: fix crash after the device is unregistered")
> Signed-off-by: liujian <liujian56@huawei.com>
> ---
> drivers/uio/uio.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
> index 5c10fc7..bde7d7a 100644
> --- a/drivers/uio/uio.c
> +++ b/drivers/uio/uio.c
> @@ -496,7 +496,7 @@ static int uio_open(struct inode *inode, struct file *filep)
> if (!idev->info) {
> mutex_unlock(&idev->info_lock);
> ret = -EINVAL;
> - goto err_alloc_listener;
> + goto err_infoopen;
> }
>
> if (idev->info && idev->info->open)
> @@ -508,6 +508,7 @@ static int uio_open(struct inode *inode, struct file *filep)
> return 0;
>
> err_infoopen:
Maybe we should rename the "err_infoopen" to something like
"err_idev_info"...
Thanks.
BRs
> + filep->private_data = NULL;
> kfree(listener);
>
> err_alloc_listener:
next prev parent reply other threads:[~2019-01-02 6:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 16:26 liujian
2019-01-02 6:36 ` Xiubo Li [this message]
2019-01-02 6:55 ` liujian (CE)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50ee4818-a154-5ea7-20f8-3c0f0859f4fa@redhat.com \
--to=xiubli@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liujian56@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®