From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from invmail3.skhynix.com (exvmail3.skhynix.com [166.125.252.90]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C9E6A173 for ; Mon, 30 Dec 2024 01:37:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=166.125.252.90 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735522660; cv=none; b=kECvcBWADhDjP3eovhrWigleII5/+QV0QRKsEq7eUQS3QLftV+gO4BMXazAsziXH5E4XKooOdoVuBK0Iw4kD5jpNXoa5VzHR0NgA68cpbO0CRGYI2veiqN6ivieIJo1UXvWcK788FQSNVn/uKhZskyZk1qx0pBiKX1T3IANvUfg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735522660; c=relaxed/simple; bh=S25LTB2jZTHWXti2bXzdEwWSJBlMDH3bH0isuGFrOlk=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=ZPQ/OvMI7S4n8stFC6rRLkexw+vBnvVEq02CtK1Rkke8RTbjRf5SnigOyAGGmxQKa8XZfWuZUEzM8jAChQN/OrZLlltoq2XxPl/FqgyGeH+CEzUpo+g8saU/lXCpVandXTFUuKfr3l9z4A/Ju1fCIsrGF6+QHsqz44loK20OupI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sk.com; spf=pass smtp.mailfrom=sk.com; arc=none smtp.client-ip=166.125.252.90 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sk.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sk.com X-AuditID: a67dfc59-7a9ff700000194b3-d3-6771f5d0308a Message-ID: <50f2f968-df8f-4067-8e19-4d1e5b8cbbfb@sk.com> Date: Mon, 30 Dec 2024 10:22:24 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: kernel_team@skhynix.com, 42.hyeyoo@gmail.com, "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andi Kleen , Andrew Morton , Yunjeong Mun Subject: Re: [PATCH] mm/mempolicy: count MPOL_WEIGHTED_INTERLEAVE to "interleave_hit" To: Honggyu Kim , Gregory Price References: <20241227095737.645-1-honggyu.kim@sk.com> Content-Language: en-US From: Hyeonggon Yoo In-Reply-To: <20241227095737.645-1-honggyu.kim@sk.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHLMWRmVeSWpSXmKPExsXC9ZZnke6Fr4XpBpO7dC0m9hhYHJ9gaTFn /Ro2i593j7NbXN41h83i3pr/rA5sHjtn3WX36G67zO6x6dMkdo8TM36zeMw7GejxeZNcAFsU l01Kak5mWWqRvl0CV0bjhNlsBbP4Kl7umcHYwPiIu4uRk0NCwERi+psDbDD2tGkzWLsYOTh4 BSwl1u8SAAmzCKhKbHh1lR3E5hUQlDg58wkLiC0qIC9x/9YMoDgXB7PAJCaJmUtXM4IkhAXC JW7O/gRmiwi4S1z495oZxBYSMJWY3bMObBezgLjErSfzmUB2sQloSezoTAUJcwqYSVz53MQK UWIm0bW1ixHClpfY/nYOM8guCYHLbBLNO58yQ9wsKXFwxQ2WCYyCs5DcNwvJillIZs1CMmsB I8sqRpHMvLLcxMwcY73i7IzKvMwKveT83E2MwFhYVvsncgfjtwvBhxgFOBiVeHgl2gvThVgT y4orcw8xSnAwK4nwnksqSBfiTUmsrEotyo8vKs1JLT7EKM3BoiTOa/StPEVIID2xJDU7NbUg tQgmy8TBKdXAmK7t+r+nSdQ2efG2H0GfPhRYv5vDsuHLN4Wzn31M0wQuBVuxfvM+M+WEpI+M VPrfCpea7qAHBnkFHLftAvTismXmXe23OBFYH1mWnNwa4ZYrtemExlOVVHvm5XbOi+wnn5ay X/wrfuPB1XfOsOpqFEsJizLcnr6ApzFEbYu575H7KRsZriQqsRRnJBpqMRcVJwIAbEtwzoEC AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrILMWRmVeSWpSXmKPExsXCNUOnRPfC18J0gy0TVSwm9hhYHJ9gaTFn /Ro2i593j7NbfH72mtni8NyTrBaXd81hs7i35j+rxe9tK9gcOD12zrrL7tHddpndY9OnSewe J2b8ZvGYdzLQ49ttD4/FLz4weXzeJBfAEcVlk5Kak1mWWqRvl8CV0ThhNlvBLL6Kl3tmMDYw PuLuYuTkkBAwkZg2bQZrFyMHB6+ApcT6XQIgYRYBVYkNr66yg9i8AoISJ2c+YQGxRQXkJe7f mgEU5+JgFpjEJDFz6WpGkISwQLjEzdmfwGwRAXeJC/9eM4PYQgKmErN71rGB2MwC4hK3nsxn AtnFJqAlsaMzFSTMKWAmceVzEytEiZlE19YuRghbXmL72znMExj5ZiE5YxaSSbOQtMxC0rKA kWUVo0hmXlluYmaOmV5xdkZlXmaFXnJ+7iZGYMAvq/0zaQfjt8vuhxgFOBiVeHgl2gvThVgT y4orcw8xSnAwK4nwnksqSBfiTUmsrEotyo8vKs1JLT7EKM3BoiTO6xWemiAkkJ5YkpqdmlqQ WgSTZeLglGpgLJ+wLpHlwyq2laGnzuUYOzY8E85fYFty94kab82eqN/MkwsnaEia/Wq9cMu5 +usu5mkFlVcOhmi9udglr74mnTt3zVLm7ct2uXj4hKk8uXP4FpNrp8vSFYfXX316iomnPFOa SXFOiILQOvuWN+Ka3OwWtQ4Nk1m3pm1Zv9p4bbHfL372vx9fKbEUZyQaajEXFScCACLQjgh0 AgAA X-CFilter-Loop: Reflected On 2024-12-27 6:57 AM, Honggyu Kim wrote: > The fa3bea4e1f82 introduced MPOL_WEIGHTED_INTERLEAVE but it missed > adding its counter to "interleave_hit" of numastat, which is located at > /sys/devices/system/node/nodeN/ directory. > > It'd be better to add weighted interleving counter info to the existing > "interleave_hit" instead of introducing a new counter > "weighted_interleave_hit". > > Fixes: fa3bea4e1f82 ("mm/mempolicy: introduce MPOL_WEIGHTED_INTERLEAVE for weighted interleaving") > Cc: Gregory Price > Cc: Andi Kleen > Signed-off-by: Honggyu Kim > --- > mm/mempolicy.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index 04f35659717a..162407fbf2bc 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -2268,7 +2268,8 @@ struct page *alloc_pages_mpol_noprof(gfp_t gfp, unsigned int order, > > page = __alloc_pages_noprof(gfp, order, nid, nodemask); > > - if (unlikely(pol->mode == MPOL_INTERLEAVE) && page) { > + if (unlikely(pol->mode == MPOL_INTERLEAVE || > + pol->mode == MPOL_WEIGHTED_INTERLEAVE) && page) { > /* skip NUMA_INTERLEAVE_HIT update if numa stats is disabled */ > if (static_branch_likely(&vm_numa_stat_key) && > page_to_nid(page) == nid) { > > base-commit: 4bbf9020becbfd8fc2c3da790855b7042fad455b [+Cc Andrew] Looks good to me, Reviewed-by: Hyeonggon Yoo We discovered that interleave_hit is not correctly accounted while testing MPOL_WEIGHTED_INTERLEAVE on libnuma and this patch fixes the issue. Tested-by: Yunjeong Mun For reference: https://github.com/numactl/numactl/pull/238#issuecomment-2563532910 -- Hyeonggon