From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=pass header.oldest-pass=0 smtp.remote-ip=165.173.180.11 ARC-Seal: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=pass; t=1793003614; b=xT7H28C8QPn/Bpj3cgt0bgL8nRFvRDP/qNfVmmI1BZaJxggCGJv7MxNTzXaMufUJbkIk RocwgWL7onQaVT7CcZMT57KzR3kpTO+zBk4oMIoqxgK86V43CegeJkVHN+yazZcEVreg/ nU+opEvW60GvDaJ9G7r3I9lnBlgGStCUXyGjgs4Sv5P1RRrOVSe4TYwxmLeWpTjlUxYpn z62989nydsSTr75z+/TpbRV45j1zecAbRO9PH/RTUPA8AjsEn/7o7f2Gzdu39/tYCFjrI EX+mRgwYskVQ24i7wLvrj9r04h9dh4Gny0uOeaxeNVYSGpKzLDG91WhtZELVJOtP4Dg== ARC-Message-Signature: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793003614; h=DMARC-Filter:DKIM-Signature:Received:Message-ID:Date:MIME-Version: User-Agent:Subject:To:References:Content-Language:From:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=XQ7CboCxab8pAsYWIP610kHz8Zg6lfgejBrE8HM31Zs=; b=suaDWqO5BuFf/h8LJ/IBVepGfU7AhmIBshAXJi3dZb8ocEpRxpnfdMX3hSKLFRqtllQF n+Wpxatc/x7PgKAw1cn5ic440jl8ZX+ECyDsLgFrOE31XukEaApAx0pWe3apluuhTJ/RN GRME5y46FIy6mUZZizTuC+XOBcVdD1MrvI43zz1vOP0PZQhDKlbxa0+1+96OS0z9+F1iv zWMQUmJY33xAU5LPrNDKpYCqlTqa69BgThIY0dykGYYWt1CLin6WSQx9XdcqMH66kX7sb 0DuEQpRznqtnKzDJ9y25OmLhWf9beHxE9JWkK8o4NAkx4+NJnS3Daw71TmGjBXdcnrA== ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass header.d=collabora.com header.i=benjamin.gaignard@collabora.com header.a=rsa-sha256 header.s=zohomail header.b=CsMkd8IX; arc=pass header.oldest-pass=0 smtp.remote-ip=165.173.180.11 Received: from sender6-op-o11.zoho.com (sender6-op-o11.zoho.com [165.173.180.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B845D606A31E for ; Mon, 26 Oct 2026 08:33:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B845D606A31E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=collabora.com header.i=benjamin.gaignard@collabora.com header.a=rsa-sha256 header.s=zohomail header.b=CsMkd8IX ARC-Seal: i=1; a=rsa-sha256; t=1793003602; cv=none; d=zohomail.com; s=zohoarc; b=IyrdESao9nTm9S0mfJqN5UgzSBIswn+wSMU9ZZ22Q0MCNpnvKA1GCw4NjTELztHi5jct1t8KQYPdbrfqT7Grdju61jcpasqqoxdZcB1bqWf7PZXrILHYvduId2KUqirblXuRLukz9NXqPbJXykyIAwTsM2wMcKblDe1GROqcNpM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1793003602; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=XQ7CboCxab8pAsYWIP610kHz8Zg6lfgejBrE8HM31Zs=; b=g2s802jJqB4dgWVaMoTWXyePntRv1Y51QiKg5bG+AjcOgk1EjY/BIB6D31ODKYBcZeTXihay+swd4yvBiMUMN9gAW9oPNjFatrsmcUD/L39cpIQsawULXJJZVUnxRy7LS0oZ7uLzR+uGwzUAMBGcZv+0AhiYd/CpNg6Y3WzDUGc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=benjamin.gaignard@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1793003602; s=zohomail; d=collabora.com; i=benjamin.gaignard@collabora.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=XQ7CboCxab8pAsYWIP610kHz8Zg6lfgejBrE8HM31Zs=; b=CsMkd8IXQTL323i3GjAip5yo+MRxELZ3R+0qUEUgkUWj/7u8mNXphT/AxF/injhq /gQ48iHLZf6qCACGC5HB7b73Aa8Y1SOijcExb9+HPfNheGvhDVIqxLehbSMjjLAOYFT 83yA43kuzYLrbgl+t9ZbmNHw2a3njQvH35wGOpjk= Received: by smtp.zohomail.com with SMTPS id 1793003597851708.4815720368576; Mon, 26 Oct 2026 01:33:17 -0700 (PDT) Message-ID: <50f5f070-49cc-4a1b-a100-5cf918fed54f@collabora.com> Date: Mon, 26 Oct 2026 09:33:14 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] iommu/vsi: keep the runtime PM callbacks without PM_SLEEP To: Daniel Golle , Joerg Roedel , Will Deacon , Robin Murphy , Joerg Roedel , iommu@lists.linux.dev, linux-kernel@vger.kernel.org References: Content-Language: en-US From: Benjamin Gaignard In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 25/10/2026 à 14:27, Daniel Golle a écrit : > The runtime PM operations are handed to the driver core through > pm_sleep_ptr(), which is NULL unless CONFIG_PM_SLEEP is set. > > Without system sleep support the IOMMU has no runtime PM callbacks at > all: its clocks are never enabled by the driver, the page table is not > restored when the power domain comes back, and iommu->enable stays set > while genpd powers the domain off. > The TLB flush issued from vsi_iommu_map() then writes to the unpowered > IOMMU, and the first buffer allocation of the RK3588 AV1 decoder ends > in an asynchronous SError. > > Use pm_ptr(), which keeps the operations whenever CONFIG_PM is set. > > Fixes: 917ace84b770 ("iommu: Add verisilicon IOMMU driver") Thanks for the patch. Reviewed-by: Benjamin Gaignard > Signed-off-by: Daniel Golle > --- > drivers/iommu/vsi-iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/vsi-iommu.c b/drivers/iommu/vsi-iommu.c > index 5dac20b143a55..1b447c0693936 100644 > --- a/drivers/iommu/vsi-iommu.c > +++ b/drivers/iommu/vsi-iommu.c > @@ -780,7 +780,7 @@ static struct platform_driver rockchip_vsi_iommu_driver = { > .driver = { > .name = "vsi_iommu", > .of_match_table = vsi_iommu_dt_ids, > - .pm = pm_sleep_ptr(&vsi_iommu_pm_ops), > + .pm = pm_ptr(&vsi_iommu_pm_ops), > .suppress_bind_attrs = true, > }, > }; > > base-commit: bd1ecbb61afefc6a8b876ccbc31e9228b44e9eab