From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA0CB364E84 for ; Tue, 16 Jun 2026 14:14:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781619287; cv=none; b=bHHKWqDudDYi531LZtkF+cz5SS/4AhL6y5USoJpvtL+KXaOSOvBDmZVnWcbhNaiF6a3qOekbVNFcPOs9q122L9q3yZqSHxWnmBc9GrxLWNMAXsQ9HCzzZXKH+36rbEiZIaotq0EoiTGx4FHMCaOnRyvHiOqdS2l598bQk7VN9uI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781619287; c=relaxed/simple; bh=irl8QxA5C9eS4raapfmrswfr3OhWo1FcTIzj3kwcHHc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sqjiY0kahviRvLsPdjvu7NtvzvqZ818duGJcD83JG98sao1eNmQJbiB/cgWWmTmaUlvt0XBtiZGHtFt3p5DF8YNf26Jt7yV/3xnNDjVm+RujFACinzuAnpCNRH5lAx6jzKBARFRwRUml+NV8727sBxx/bUX00StDIEC5Kf0W4F4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QAM1kyVT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cUsvkNr8; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QAM1kyVT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cUsvkNr8" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65GDxc6e3432054 for ; Tue, 16 Jun 2026 14:14:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0hAx854ISARB3ER/A8NJSDIfIV15g1Oji8K44z4BCu0=; b=QAM1kyVTARUAiUx1 HwN+Rt6ZPoLOrdawDoHFv7Fqdc32iTUYp39m0XzMLGHkpcqd0xkq3fZgHcaemSmN ANGPium+D5z1xual38fwaYY0vF/sHhoJ6Qglc3O7zImBcQbIu6aPNpiFueoVY7Wk OhvRw2QYbY6ukTECrhwTWbCr+mxQjrvSgMWy9VEz44c4mV8SVxkLqacih9//O6nh GDzAvqhArXNn/Sg28e/MY+SsHZ0p2+409jVroHjrIULgFyj+hZFtPLzQY3RkPkRL sO9NSscH/uSIWI3FrcEPfDskndnhaRb5hwOjaUv+7ogTIeycvXbhZwIvFzaQBNQr N/5jHA== Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eu17620u2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Jun 2026 14:14:46 +0000 (GMT) Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-6c4b898e8d8so220944137.0 for ; Tue, 16 Jun 2026 07:14:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781619285; x=1782224085; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0hAx854ISARB3ER/A8NJSDIfIV15g1Oji8K44z4BCu0=; b=cUsvkNr8aM7a+6Sca1olvc/J3uuAVC42YaKvMrAm5oPJ53s2paflvxyf9AAZha1zOe 7fWLGUAxvatzyDgoJ9jM1aFCE9RpJl3JYPJoTKUwRmINMdtpmzTRUSYsyJO+GmWkqiOm zyOlOcA9095VwaWT9TBAK4pnXUHJGyyB5lhb8cp1GA7VX6szrakJdOMxmchvJ/kpLy41 2Phm5+aS7k9H3FRRKqVk2tYaC/dJ3foPTKPdGdYtDFLvJb4aaCOi0FjXMDKKamCHfMqB A9nOPnagJu4PTMqdS00qkzRPdJNhtsBFdgvEHYGXeOahS8ogRXr91waJPUhRoMkMlu22 bT5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781619285; x=1782224085; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0hAx854ISARB3ER/A8NJSDIfIV15g1Oji8K44z4BCu0=; b=fIlfWNq+34eSUtnurgOK/4cenYsxQerHX0NLzde3xHuk1tEaGLZiKMdTKFnSIEX4Xq PAdz6ruUKVkx6dvQXygEVeSDZWuIXPC6y/ev2apfVVjHdGBZcvacVWCfQYi+ZTiOdeBk dHafbvN4kXcUpMWcOeeR+wQx4JrAU653XUksp/PY9ckhuofnfHm1vWIaxSAvgyhPqZfV JlKMEKNTIE3dQUrMoVFiOatg9fyGAlQjJy4DGJnwyz6pSxbwj5iCKAxOICRqmDdO7iGw UDNvfMrDC4mUAjpx7m3fGPkucS39zlV+OnpdEdrECcS2hYyGH4W1d8MN0JHnuoU7Hle2 EupQ== X-Forwarded-Encrypted: i=1; AFNElJ/Ed0jeBdCiuyp95lKASL755SU4oykwx7gbRE484yoocYFUVPVSJYAXfmfcNebUmQ1lDvx8gIN4uNaXWIk=@vger.kernel.org X-Gm-Message-State: AOJu0YwyX6khuEAuilQAgMVakoJ8bsV6A4yNRkcUGs032QiHbc0t3XzM YUeC/HbrW59MZgXEGxD2qw9BARVOpi9ENaV1J4pLmFdYksIKIw9Pr2P/+pXjAJ+MnkHBb5ZUJx3 kDh7lZ2hhC7WHOJdrclWaUxFUWKGmfNzsGRKL/4PoDva+HX4pm6d4PulJaLMTXkhUhTY= X-Gm-Gg: Acq92OGy0DMK952yCYorT6j4WV/MmDQPBTLyXiquJdbWSXNixmZBraf1U2bf6pBjIBs GnjX3bdizoB3xJig7Ur7wFTDvhkR5qzbeJ7KGq3mRm3YyUSXfIwKJpJEF/PVGOdmWcXndy6QF8m Bfl+FKvHJiJ+9qmOlASSK2GqzoumISf7FUg3W6EBcDNSYCU+7Dw48Y2iieQVXzFwqldc9vNjPQJ 5/yiCHszGm1WTDuFmYUss5jqUrCAKFfPHlRV3qUqTnY97fQmvtTdSBXikYrTAon+0D8S0hrUe+E OKXYYoIZjQdVHMn26dDtO4VjcuvmAy4cKGlKxjEA8IaP4XjfDi+GH55t7RXJndm/nGt/eBPdLwG vkOCLfpTB+7xdfXBWLDyu2KcZxUd0K8TL5Rz1OXVcdB2RJg== X-Received: by 2002:a05:6102:510b:b0:631:4d32:a86 with SMTP id ada2fe7eead31-71e88e3f21emr2770723137.7.1781619285154; Tue, 16 Jun 2026 07:14:45 -0700 (PDT) X-Received: by 2002:a05:6102:510b:b0:631:4d32:a86 with SMTP id ada2fe7eead31-71e88e3f21emr2770699137.7.1781619284575; Tue, 16 Jun 2026 07:14:44 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bfdb7b6d8c2sm638601966b.38.2026.06.16.07.14.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2026 07:14:43 -0700 (PDT) Message-ID: <50f7eb11-7bac-4d45-9e0a-b209f7e8e9f6@oss.qualcomm.com> Date: Tue, 16 Jun 2026 16:14:39 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 3/9] net: stmmac: qcom-ethqos: fix RGMII_ID mode to use DLL bypass To: Andrew Lunn , Mohd Ayaan Anwar , Bjorn Andersson , Bartosz Golaszewski , Eric Chanudet , Lucas Karpinski , Andrew Halaney Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Maxime Coquelin , Alexandre Torgue , Russell King , linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org References: <20260612-shikra_ethernet-v1-0-f0f4a1d19929@oss.qualcomm.com> <20260612-shikra_ethernet-v1-3-f0f4a1d19929@oss.qualcomm.com> <42355330-c22a-4fce-98ab-dc22b321ff16@lunn.ch> <82705420-771d-41bf-a4d9-ed94dff86ff0@lunn.ch> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <82705420-771d-41bf-a4d9-ed94dff86ff0@lunn.ch> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: M6yXdx-kIYI-ObiRcRs25_arn6jHPsA- X-Proofpoint-ORIG-GUID: M6yXdx-kIYI-ObiRcRs25_arn6jHPsA- X-Authority-Analysis: v=2.4 cv=I4RVgtgg c=1 sm=1 tr=0 ts=6a315a56 cx=c_pps a=P2rfLEam3zuxRRdjJWA2cw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=RaRby332RutXx2QLMF0A:9 a=QEXdDO2ut3YA:10 a=ODZdjJIeia2B_SHc_B0f:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE2MDE0NSBTYWx0ZWRfXypEFndBOIN3P W9gdfuFyRNFakpJUeVl+d1x/exKfE13oBAMMOHDnYQHkIiDsceO4ziwj1t/mGi3c74V0e2aVhG2 uqthwlHvNqnFdoL70G3PenjqE/6++Go= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE2MDE0NSBTYWx0ZWRfX5NznPkJf7EFn MlLG3oER72ga7EpLyrJVu7VLclqM/BBVhtEuCK9xWI06q1ekKAHZnUmHGElWkX6SU/NJXk68dzO BoawocZqZEQ2L5unZhfwTk0b1GXCQuxHfRMUbgsQNL3IWYYKx3nKE2e1KglHG6ePHfq9YyJRlNI /BYWPhOIMJlDtJ0bW7jTTAeclKifaXCGRaM9Ge8LYnBwdv5HkWRiV/ISSkTWAy4QNTWkyeNVyim +M4T9kgE/l9ttwzmiG30Y6IP2uoZn+381VLvofCApOsRaUseBu5okVoRRszygEqX6QKZEztZ7no zrVTGO8JtUbe3rqrRlDgBul9e39FFB+g24UVT0DhbCLUfM+9GB9vZ1nygDFqiWzdNl/ub9KvX5W eY/3Zt1hwwVC5gdx132+pG+XbTIRhZjArbJlF6R4a3Fpdtd+uSQFkU8PboK2Wy4iSZ/45KYmhFQ Z/z1uykfpysc7O/1VHQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-16_04,2026-06-15_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606160145 On 6/15/26 6:48 PM, Andrew Lunn wrote: > On Mon, Jun 15, 2026 at 09:24:07AM +0530, Mohd Ayaan Anwar wrote: >> Hello Andrew, >> On Thu, Jun 11, 2026 at 10:54:37PM +0200, Andrew Lunn wrote: >>> On Fri, Jun 12, 2026 at 12:06:59AM +0530, Mohd Ayaan Anwar wrote: >>>> When "rgmii-id" is selected the PHY supplies both TX and RX delays, so >>>> the MAC must not add its own. The driver currently falls through to the >>>> generic DLL initialisation path which programs it to add a delay. >>>> >>>> Power down the DLL and set DDR bypass mode for RGMII_ID, then program >>>> the IO_MACRO via a new ethqos_rgmii_id_macro_init() helper. Also fix >>>> ethqos_set_clk_tx_rate() to not double the clock rate in bypass mode at >>>> 100M/10M, and remove RGMII_ID from the phase-shift suppression in >>>> ethqos_rgmii_macro_init() since RGMII_ID no longer reaches that path. >>> >>> I'm curious how this works at the moment? Do no boards make use of >>> RGMII ID? Are all current boards broken? >> >> Searching through the DTS, I found that we have two boards using "rgmii" >> (qcs404-evb-4000.dts and sa8155-adp.dts) and another board using >> "rgmii-txid" (sa8540p-ride.dts). No board which uses RGMII ID. > > So this causes problems. We cannot break existing boards, yet it would > be good to fix the current broken behaviour. These are a funny bunch.. QCS404 is a stuck in a perpetual cycle of "no one has the hardware" and "someone has the hw but zero interest or time". I think we've considered it for removal at one point.. I'm not sure to what degree the two SA8xxx boards are used. They may have been stuck in some sort of a limbo. Maybe Bjorn knows? Also +Cc some of the folks that contributed to them in the past Konrad