mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "André Almeida" <andrealmeid@igalia.com>
To: Hamza Mahfooz <hamza.mahfooz@amd.com>
Cc: pierre-eric.pelloux-prayer@amd.com,
	"'Marek Olšák'" <maraeo@gmail.com>,
	"Michel Dänzer" <michel.daenzer@mailbox.org>,
	intel-gfx@lists.freedesktop.org,
	"Randy Dunlap" <rdunlap@infradead.org>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	"Pekka Paalanen" <ppaalanen@gmail.com>,
	kernel-dev@igalia.com, alexander.deucher@amd.com,
	christian.koenig@amd.com, xaver.hugl@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 0/4] drm: Add support for atomic async page-flip
Date: Wed, 22 Nov 2023 17:28:35 -0300	[thread overview]
Message-ID: <50ff86d4-5ce1-4ae5-aafb-ce3bc0069629@igalia.com> (raw)
In-Reply-To: <cc10f6b0-e26e-4021-85ca-33cb1e58e937@amd.com>

Hi Hamza,

Em 22/11/2023 17:23, Hamza Mahfooz escreveu:
> Hi André,
> On 11/22/23 11:19, André Almeida wrote:
>> Hi,
>>
>> This work from me and Simon adds support for DRM_MODE_PAGE_FLIP_ASYNC 
>> through
>> the atomic API. This feature is already available via the legacy API. 
>> The use
>> case is to be able to present a new frame immediately (or as soon as
>> possible), even if after missing a vblank. This might result in 
>> tearing, but
>> it's useful when a high framerate is desired, such as for gaming.
>>
>> Differently from earlier versions, this one refuses to flip if any 
>> prop changes
>> for async flips. The idea is that the fast path of immediate page 
>> flips doesn't
>> play well with modeset changes, so only the fb_id can be changed.
>>
>> Tested with:
>>   - Intel TigerLake-LP GT2
>>   - AMD VanGogh
> 
> Have you had a chance to test this with VRR enabled? Since, I suspect
> this series might break that feature.
> 

Someone asked this question in an earlier version of this patch, and the 
result is that VRR still works as expected. You can follow the thread at 
this link:

https://lore.kernel.org/lkml/b48bd1fc-fcb0-481b-8413-9210d44d709b@igalia.com/

I should have included this note at my cover letter, my bad.

Thanks,
	André

  reply	other threads:[~2023-11-22 20:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-22 16:19 André Almeida
2023-11-22 16:19 ` [PATCH v9 1/4] drm: Refuse to async flip with atomic prop changes André Almeida
2023-11-22 16:19 ` [PATCH v9 2/4] drm: allow DRM_MODE_PAGE_FLIP_ASYNC for atomic commits André Almeida
2023-11-22 16:19 ` [PATCH v9 3/4] drm: introduce DRM_CAP_ATOMIC_ASYNC_PAGE_FLIP André Almeida
2023-11-22 16:19 ` [PATCH v9 4/4] drm/doc: Define KMS atomic state set André Almeida
2023-11-22 20:23 ` [PATCH v9 0/4] drm: Add support for atomic async page-flip Hamza Mahfooz
2023-11-22 20:28   ` André Almeida [this message]
2023-11-23 16:24     ` Simon Ser
2023-11-23 16:26       ` André Almeida

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50ff86d4-5ce1-4ae5-aafb-ce3bc0069629@igalia.com \
    --to=andrealmeid@igalia.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hamza.mahfooz@amd.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=kernel-dev@igalia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maraeo@gmail.com \
    --cc=michel.daenzer@mailbox.org \
    --cc=pierre-eric.pelloux-prayer@amd.com \
    --cc=ppaalanen@gmail.com \
    --cc=rdunlap@infradead.org \
    --cc=xaver.hugl@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®