From: Laxman Dewangan <ldewangan@nvidia.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Graeme Gregory <gg@slimlogic.co.uk>,
Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
AnilKumar Ch <anilkumar@ti.com>
Subject: Re: [PATCH 2/2] regulator: tps65910: Fix using wrong dev argument for calling of_regulator_match
Date: Thu, 24 Jan 2013 10:15:59 +0530 [thread overview]
Message-ID: <5100BC87.30301@nvidia.com> (raw)
In-Reply-To: <1358994705.20257.4.camel@phoenix>
On Thursday 24 January 2013 08:01 AM, Axel Lin wrote:
> The dev parameter is the device requesting the data.
> In this case it should be &pdev->dev rather than pdev->dev.parent.
>
> The dev parameter is used to call devm_kzalloc in of_get_regulator_init_data(),
> which means this fixes a memory leak because the memory is allocated every time
> probe() is called, thus it should be freed when this driver is unloaded.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
Agree with the change.
Acked-by: Laxman Dewangan<ldewangan@nvidia.com>
next prev parent reply other threads:[~2013-01-24 4:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 2:27 [PATCH 1/2] regulator: tps65217: " Axel Lin
2013-01-24 2:31 ` [PATCH 2/2] regulator: tps65910: " Axel Lin
2013-01-24 4:45 ` Laxman Dewangan [this message]
2013-01-24 17:02 ` gg
2013-01-29 0:03 ` Stephen Warren
2013-01-29 3:39 ` Mark Brown
2013-01-29 18:46 ` Stephen Warren
2013-01-24 4:52 ` [PATCH 1/2] regulator: tps65217: " Mark Brown
[not found] ` <CAFRkauDdbYH2jm_TXypjhe0rWyEOpS-JqZ1G4-WZmFKFJngbkw@mail.gmail.com>
2013-01-24 10:00 ` Mark Brown
2013-01-24 11:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5100BC87.30301@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=anilkumar@ti.com \
--cc=axel.lin@ingics.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gg@slimlogic.co.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome