From: Stephen Warren <swarren@wwwdotorg.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
"David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH] nl80211: avoid "wdev_id may be used uninitialized"
Date: Wed, 30 Jan 2013 09:49:20 -0700 [thread overview]
Message-ID: <51094F10.60605@wwwdotorg.org> (raw)
In-Reply-To: <1359532679.8010.1.camel@jlt4.sipsolutions.net>
On 01/30/2013 12:57 AM, Johannes Berg wrote:
> On Tue, 2013-01-29 at 17:11 -0700, Stephen Warren wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> Silence the following:
>> net/wireless/nl80211.c: In function '__cfg80211_wdev_from_attrs.clone.119':
>> net/wireless/nl80211.c:57:6: warning: 'wdev_id' may be used uninitialized in this function
>>
>> ... by always initializing wdev_id to zero. I assume that wiphy_idx and
>> ifidx are set to -1 for similar reasons, so this change simply propagates
>> the same workaround.
>>
>> In practice, this warning is false, since wdev_id is both set and used
>> under the condition if (have_wdev_id). However, at least my compiler
>> can't be coerced into realizing this; almost any code between the if
>> blocks that set and use the variable causes this warning.
>
> I don't see this warning? What compiler are you using?
I'm using gcc-4.5.3 for ARM. I checked with gcc-4.6.3 and gcc-4.7.2 and
indeed I don't see the warning there.
next prev parent reply other threads:[~2013-01-30 16:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-30 0:11 Stephen Warren
2013-01-30 7:57 ` Johannes Berg
2013-01-30 16:49 ` Stephen Warren [this message]
2013-01-31 20:51 ` Johannes Berg
2013-01-31 22:21 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51094F10.60605@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®