From: Ian Abbott <abbotti@mev.co.uk>
To: Sebastiaan de Haan <sebastiaan@sebastiaandehaan.nl>
Cc: Ian Abbott <ian.abbott@mev.co.uk>,
"fmhess@users.sourceforge.net" <fmhess@users.sourceforge.net>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"hsweeten@visionengravers.com" <hsweeten@visionengravers.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Staging: comedi: made range.c checkpatch.pl compliant
Date: Thu, 31 Jan 2013 11:02:42 +0000 [thread overview]
Message-ID: <510A4F52.7050008@mev.co.uk> (raw)
In-Reply-To: <20130131105648.GB18894@f-lin01.localdomain>
On 2013-01-31 10:56, Sebastiaan de Haan wrote:
> Change made to range.c to make it checkpatch.pl compliant
>
> Signed-off-by: Sebastiaan de Haan <sebastiaan@sebastiaandehaan.nl>
> ---
> drivers/staging/comedi/range.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/range.c b/drivers/staging/comedi/range.c
> index 59ff0cf..b87fb4e 100644
> --- a/drivers/staging/comedi/range.c
> +++ b/drivers/staging/comedi/range.c
> @@ -35,7 +35,7 @@ const struct comedi_lrange range_unipolar10 = { 1, {UNI_RANGE(10)} };
> EXPORT_SYMBOL(range_unipolar10);
> const struct comedi_lrange range_unipolar5 = { 1, {UNI_RANGE(5)} };
> EXPORT_SYMBOL(range_unipolar5);
> -const struct comedi_lrange range_unknown = { 1, {{0, 1000000, UNIT_none} } };
> +const struct comedi_lrange range_unknown = { 1, {{0, 1000000, UNIT_NONE} } };
> EXPORT_SYMBOL(range_unknown);
No, no, no. It doesn't compile and UNIT_none is used by user space.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
prev parent reply other threads:[~2013-01-31 11:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 10:56 Sebastiaan de Haan
2013-01-31 11:02 ` Ian Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510A4F52.7050008@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=fmhess@users.sourceforge.net \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=ian.abbott@mev.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastiaan@sebastiaandehaan.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®