mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Li Zefan <lizefan@huawei.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Kent Overstreet <koverstreet@google.com>,
	<linux-kernel@vger.kernel.org>, <linux-bcache@vger.kernel.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH 3/4] Export blk_fill_rwbs()
Date: Fri, 1 Feb 2013 11:57:30 +0800	[thread overview]
Message-ID: <510B3D2A.3040007@huawei.com> (raw)
In-Reply-To: <1359690521.5642.10.camel@gandalf.local.home>

on 2013/2/1 11:48, Steven Rostedt wrote:
> Li,
> 
> Can you give an Ack or Nack for this.
> 

I think this patch shouldn't go into upstream without bcache code. We don't
export symbols for out of tree code.

> Thanks,
> 
> -- Steve
> 
> 
> On Tue, 2013-01-15 at 13:25 -0800, Kent Overstreet wrote:
>> Exported so it can be used by bcache's tracepoints
>>
>> Signed-off-by: Kent Overstreet <koverstreet@google.com>
>> CC: Steven Rostedt <rostedt@goodmis.org>
>> CC: Frederic Weisbecker <fweisbec@gmail.com>
>> CC: Ingo Molnar <mingo@redhat.com>
>> ---
>>  kernel/trace/blktrace.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
>> index c0bd030..dbe1667 100644
>> --- a/kernel/trace/blktrace.c
>> +++ b/kernel/trace/blktrace.c
>> @@ -1806,6 +1806,7 @@ void blk_fill_rwbs(char *rwbs, u32 rw, int bytes)
>>  
>>  	rwbs[i] = '\0';
>>  }
>> +EXPORT_SYMBOL_GPL(blk_fill_rwbs);
>>  
>>  #endif /* CONFIG_EVENT_TRACING */
>>  
> 
> 
> 


  reply	other threads:[~2013-02-01  3:57 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-14 22:32 Bcache v. whatever Kent Overstreet
2013-01-15  1:49 ` Greg KH
2013-01-15 21:18   ` Kent Overstreet
2013-01-15 22:50     ` Greg KH
2013-01-15  9:20 ` James Bottomley
2013-01-15 20:59   ` Kent Overstreet
2013-01-15 23:15     ` James Bottomley
2013-01-15 23:33       ` Kent Overstreet
2013-01-16  1:29         ` Alasdair G Kergon
2013-01-17 23:43           ` Mike Snitzer
2013-01-15 21:25 ` [PATCH 1/4] Revert "rw_semaphore: remove up/down_read_non_owner" Kent Overstreet
2013-01-15 21:25 ` [PATCH 2/4] Export get_random_int() Kent Overstreet
2013-01-15 21:25 ` [PATCH 3/4] Export blk_fill_rwbs() Kent Overstreet
2013-02-01  3:48   ` Steven Rostedt
2013-02-01  3:57     ` Li Zefan [this message]
2013-02-01  4:06       ` Steven Rostedt
2013-01-15 21:25 ` [PATCH 4/4] Export __lockdep_no_validate__ Kent Overstreet
2013-04-25 23:17 ` Bcache v. whatever Andrew Morton
2013-04-26 19:46   ` Kent Overstreet
2013-04-26 20:24     ` Andrew Morton
2013-04-26 20:54       ` Kent Overstreet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=510B3D2A.3040007@huawei.com \
    --to=lizefan@huawei.com \
    --cc=fweisbec@gmail.com \
    --cc=koverstreet@google.com \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome