From: Li Zefan <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Cgroups <cgroups@vger.kernel.org>,
Davide Libenzi <davidel@xmailserver.org>,
Aaron Durbin <adurbin@google.com>,
Greg Thelen <gthelen@google.com>
Subject: [PATCH 4/4] cgroup: adapt to the new way of detecting cgroup removal
Date: Sat, 2 Feb 2013 14:51:51 +0800 [thread overview]
Message-ID: <510CB787.80003@huawei.com> (raw)
In-Reply-To: <510CB733.2080904@huawei.com>
If read() returns with errno == EIDRM, we know the cgroup has been
removed.
Signed-off-by: Li Zefan <lizefan@huawei.com>
---
tools/cgroup/cgroup_event_listener.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/tools/cgroup/cgroup_event_listener.c b/tools/cgroup/cgroup_event_listener.c
index 4eb5507..19e3d4a 100644
--- a/tools/cgroup/cgroup_event_listener.c
+++ b/tools/cgroup/cgroup_event_listener.c
@@ -62,18 +62,16 @@ int main(int argc, char **argv)
if (ret == -1) {
if (errno == EINTR)
continue;
- err(1, "Cannot read from eventfd");
+ if (errno != EIDRM)
+ err(1, "Cannot read from eventfd");
}
- assert(ret == sizeof(result));
- ret = access(event_control_path, W_OK);
- if ((ret == -1) && (errno == ENOENT)) {
- puts("The cgroup seems to have removed.");
+ if (ret == -1 && errno == EIDRM) {
+ puts("The cgroup has been removed.");
break;
}
- if (ret == -1)
- err(1, "cgroup.event_control is not accessible any more");
+ assert(ret == sizeof(result));
printf("%s %s: crossed\n", argv[1], argv[2]);
}
--
1.8.0.2
next prev parent reply other threads:[~2013-02-02 6:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-02 6:50 [PATCH 0/4] cgroup: bug fixes for eventfd Li Zefan
2013-02-02 6:50 ` [PATCH 1/4] eventfd: introduce eventfd_signal_hangup() Li Zefan
2013-02-02 15:58 ` Kirill A. Shutemov
2013-02-04 10:15 ` Kirill A. Shutemov
2013-02-05 3:40 ` Li Zefan
2013-02-05 8:28 ` Kirill A. Shutemov
2013-02-06 1:48 ` Li Zefan
2013-02-06 14:53 ` Kirill A. Shutemov
2013-02-02 6:51 ` [PATCH 2/4] cgroup: fix cgroup_rmdir() vs close(eventfd) race Li Zefan
2013-02-02 15:59 ` Kirill A. Shutemov
2013-02-02 6:51 ` [PATCH 3/4] eventfd: make operations on eventfd return -EIDRM if it's hung up Li Zefan
2013-02-02 16:12 ` Kirill A. Shutemov
2013-02-04 3:15 ` Li Zefan
2013-02-02 6:51 ` Li Zefan [this message]
2013-02-02 6:59 ` [PATCH 0/4] cgroup: bug fixes for eventfd Li Zefan
2013-02-04 19:27 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510CB787.80003@huawei.com \
--to=lizefan@huawei.com \
--cc=adurbin@google.com \
--cc=cgroups@vger.kernel.org \
--cc=davidel@xmailserver.org \
--cc=gthelen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome