From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6215B17555 for ; Wed, 25 Mar 2026 12:30:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774441845; cv=none; b=J+VrwlcXBQp1LO3Nz0FPKlLcBz/eN07LeVK1VD9HJQk3mU887QGqqNY2zV7+dhVGCe0yPyQshYkWpuNWwRtwd0D31t4HXDR0MmZuYuFncK6g5mcyjJkoYLjI1Zygw0MPSUTVkVOSwgATsCNMMMuS8Su8U7FkVwnteqsYO+PaJts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774441845; c=relaxed/simple; bh=eW8kpaempfoOD2PkQU4ZCS5kv+yUGMeXcQOzVD1ag18=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=fngrW9431EiD6sj9tHXtaGDhmqFAESoy+a+R57YmHUwm7hQo1DaI/IpWsDAGUJjemZTob5oNNx/PeOB/jUhCVgFzkgUo2UaU6oeNpN8B4xtRvLQ8QH5EH7cKCA1CCH7oCho10MuHd4x8jnJGExwaeBduPocJQBG4sIg+ULUe6gU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=n0/AknVX; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n0/AknVX" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4852b81c73aso45572945e9.3 for ; Wed, 25 Mar 2026 05:30:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774441843; x=1775046643; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=AUT5pxZXZKBVWVTz66dzQVLCyUuxaud/nyfeqc23uAs=; b=n0/AknVXuSpI2SNPr4J7342FmwqKdO5TBkQj8GVGsk/0lXMzEyLgNqp0WsQJCbyi93 4fFcrh8eNJ1gEwifFNLDODWkoeuxkW3+kJHwX4YoX9dfB0BW+A+UeEELH4GTtPAt2K5H 4NB+vNjiWXAHDkTNkOF+6/BLkS2eUaV4M9uB6er4WhwB8+5kB9S1i1sZiYLxH7xn6do8 EOlo8YNCANF1rN8GAYaFhO05YTaOibTMSd23k0oxlhHGu2cCRacXOaSDZFFGxYVZkfjl 5564ob5F1yzdLPhfq3H6IJ343lVbDO+bI7rn+OOaJ2KZcFwXl8gissPEKKsDlVb0Tg6b P8OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774441843; x=1775046643; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AUT5pxZXZKBVWVTz66dzQVLCyUuxaud/nyfeqc23uAs=; b=sfJ+R4fvFRtxkFw50xJXLxSUzVPB61Lf0KPlUIPPbGEPkWK4mjRVPw/O4qGlhIuFLh WiMMnbhpKgKbK9z3sn7ZKgF91DFpzRjqHrbCMKao3/4yR1EYMjV4RrGPwHxOZjFl26nn g8qZLV3whhip9/uOzfv6sZrkWoHmNNcJFH51dHamVqFgU4XojgpLsxUYTQBbedaQUngu sXJ53PK5Tyg5myAp1c3fLyi1cxJr52rDbAmkkqNoUQJ6/8v8xKMizZp4NXa2kqWHDhGj nNbEUgusPZ4D424QS8ZYd2I07oPkIQ2iuIE1e+tZUJJmzbd28n/tpMWjqB2rqlNyQP8H 95PA== X-Forwarded-Encrypted: i=1; AJvYcCUc5PaOy2l6lcY4fIZS80G+gnzXkiSwzrGc3GbS2tj20BFb5vqCw4tp+vCDRfThFrbB26SDZTOZpC3fybA=@vger.kernel.org X-Gm-Message-State: AOJu0YzKO5SDv+K49qx/H5fP5PoA4K9H6TsTVKSjxzmnLMSZaY8fwCrC t7loIy9lNP1BU5U+TFrJpkGl3Q7tIIQxwzYlcYkgj4j3+xVB3Icj63GR X-Gm-Gg: ATEYQzy1EsY75UlZvrNHLTtub2LZBllDAbn8YUFa1/Xc3CzWei3aVTeUVwKoGgpdNa2 HTtJqsfn2E88CSUgoD3CDuuPYPDDgpOk8Knibfxv5bIzH1hjXGuijJHA90QfA0tDA0ZI8NLOPt9 /iscdYEggDsxTEvjFZIqXu+E0OsXvNLW7dvW4BUDnGwrNwQIojgL3JXE4+3X7kxTLoqxEL4H72g 4EtqOdSKt748F7d0Ur+tA4IDwuTlaZuoBVFRC9r3kmfUBvKgZWbKbBW8a+qVBDcYNHPiO5UiHYm sFn2sPgH+4A5vPy9T8DwGoCxMXAhdXWoTViR3CQN7RpWSlJwCZXKNj7oD3jqULH7ZfNj6tPpb3C IrhyrEEuoshTmUcE7tORp/XCOiaYfRLH7F5fnZa2G29Czp1ouIbDjuP2crU0M8o2/LPoy3iHr+x vMxrwVuOrsKy02yWoGZ1IcpH6TuFVVbpXjdC769k1jAQ== X-Received: by 2002:a05:600c:4705:b0:486:fc4a:2951 with SMTP id 5b1f17b1804b1-48716083231mr51669045e9.28.1774441842471; Wed, 25 Mar 2026 05:30:42 -0700 (PDT) Received: from [192.168.1.187] ([148.63.225.166]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-487116ac0a8sm223803905e9.6.2026.03.25.05.30.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 05:30:42 -0700 (PDT) Message-ID: <510e9313c229341f963508ca480ef6e5c5342b75.camel@gmail.com> Subject: Re: [PATCH] iio: light: veml6070: fix veml6070_read() return value From: Nuno =?ISO-8859-1?Q?S=E1?= To: Aldo Conte , Jonathan Cameron Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , Javier Carrasco Date: Wed, 25 Mar 2026 12:31:29 +0000 In-Reply-To: <20260325113216.170357-1-aldocontelk@gmail.com> References: <20260325113216.170357-1-aldocontelk@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2026-03-25 at 12:32 +0100, Aldo Conte wrote: > veml6070_read() computes the sensor value in ret but > returns 0 instead of the actual result. This causes > veml6070_read_raw() to always report 0. >=20 > Return the computed value instead of 0. >=20 > Running make W=3D1 returns no errors. I was unable > to test the patch because I do not have the hardware. > Found by code inspection. >=20 > Fixes: bb18885ed823 ("iio: light: veml6070: add support for integration t= ime") > Signed-off-by: Aldo Conte > --- Makes sense... Reviewed-by: Nuno S=C3=A1 > =C2=A0drivers/iio/light/veml6070.c | 4 +--- > =C2=A01 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/drivers/iio/light/veml6070.c b/drivers/iio/light/veml6070.c > index 6d4483c85f30..74d7246e5225 100644 > --- a/drivers/iio/light/veml6070.c > +++ b/drivers/iio/light/veml6070.c > @@ -134,9 +134,7 @@ static int veml6070_read(struct veml6070_data *data) > =C2=A0 if (ret < 0) > =C2=A0 return ret; > =C2=A0 > - ret =3D (msb << 8) | lsb; > - > - return 0; > + return (msb << 8) | lsb; > =C2=A0} > =C2=A0 > =C2=A0static const struct iio_chan_spec veml6070_channels[] =3D {