From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754100AbdCOPuC (ORCPT ); Wed, 15 Mar 2017 11:50:02 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35661 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753881AbdCOPt7 (ORCPT ); Wed, 15 Mar 2017 11:49:59 -0400 Subject: Re: [PATCH 1/1] fentry: x86, cleanup function_hook uses To: Steven Rostedt References: <20170315134436.23674-1-jslaby@suse.cz> <20170315114017.30eb3c31@gandalf.local.home> Cc: mingo@redhat.com, linux-kernel@vger.kernel.org, Thomas Gleixner , "H. Peter Anvin" , x86@kernel.org, Frederic Weisbecker From: Jiri Slaby Message-ID: <5110276c-7a4f-77b9-6ffb-efcfa4734b60@suse.cz> Date: Wed, 15 Mar 2017 16:49:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20170315114017.30eb3c31@gandalf.local.home> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/15/2017, 04:40 PM, Steven Rostedt wrote: >> -#else >> -# define function_hook mcount >> -EXPORT_SYMBOL(mcount) >> -#endif >> - >> /* All cases save the original rbp (8 bytes) */ >> #ifdef CONFIG_FRAME_POINTER >> # ifdef CC_USING_FENTRY >> @@ -297,6 +290,7 @@ trace: >> jmp fgraph_trace >> END(function_hook) >> #endif /* CONFIG_DYNAMIC_FTRACE */ >> +EXPORT_SYMBOL(function_hook) > > Under certain configs, this will fail the build. EXPORT_SYMBOL() does > not take the function_hook as a macro nicely. See commit 5de0a8c0c24033. Ok, thanks, forget about it then. I had the patch in my tree since Feb 3 2014, so I can finally drop it... -- js suse labs