From: "Andrew F. Davis" <afd@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
<alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] ASoC: codecs: tas5720: add TAS5722 TDM slot width setting support
Date: Mon, 15 Jan 2018 08:50:38 -0600 [thread overview]
Message-ID: <5111739c-df33-6a75-5ccf-2a2dc79f015d@ti.com> (raw)
In-Reply-To: <20171212120232.GI16323@sirena.org.uk>
On 12/12/2017 06:02 AM, Mark Brown wrote:
> On Mon, Dec 11, 2017 at 01:01:57PM -0600, Andrew F. Davis wrote:
>
>> + /* Configure TDM slot width. This is only applicable to TAS5722. */
>> + if (tas5720->devtype == TAS5722) {
>> + ret = snd_soc_update_bits(codec, TAS5722_DIGITAL_CTRL2_REG,
>> + TAS5722_TDM_SLOT_16B,
>> + slot_width == 16 ?
>> + TAS5722_TDM_SLOT_16B : 0);
>> + if (ret < 0)
>> + goto error_snd_soc_update_bits;
>> + }
>
> Use a switch statement, that way additional variants can be handled more
> sensibly.
>
Will fix.
prev parent reply other threads:[~2018-01-15 14:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 19:01 [PATCH 1/4] ASoC: codecs: tas5720: add basic support for TAS5722 devices Andrew F. Davis
2017-12-11 19:01 ` [PATCH 2/4] ASoC: codecs: tas5720: add TAS5722 register support Andrew F. Davis
2017-12-11 19:01 ` [PATCH 3/4] ASoC: codecs: tas5720: add TAS5722 specific volume control Andrew F. Davis
2017-12-12 12:01 ` Mark Brown
2018-01-15 14:50 ` Andrew F. Davis
2018-01-15 16:41 ` Mark Brown
2017-12-11 19:01 ` [PATCH 4/4] ASoC: codecs: tas5720: add TAS5722 TDM slot width setting support Andrew F. Davis
2017-12-12 12:02 ` Mark Brown
2018-01-15 14:50 ` Andrew F. Davis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5111739c-df33-6a75-5ccf-2a2dc79f015d@ti.com \
--to=afd@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®