From: "Christian König" <christian.koenig@amd.com>
To: Jingyu Wang <jingyuwang_vip@163.com>,
alexander.deucher@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie,
daniel@ffwll.ch, Felix.Kuehling@amd.com
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] amd: amdgpu: fix coding style issue
Date: Sun, 4 Sep 2022 16:13:18 +0200 [thread overview]
Message-ID: <5112955e-3f1a-be3f-a07d-afd0923ac26a@amd.com> (raw)
In-Reply-To: <20220904092625.1007393-1-jingyuwang_vip@163.com>
Am 04.09.22 um 11:26 schrieb Jingyu Wang:
> This is a patch to the amdgpu_sync.c file that fixes some warnings found by the checkpatch.pl tool
>
> Signed-off-by: Jingyu Wang <jingyuwang_vip@163.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c
> index 504af1b93bfa..dfc787b749b2 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c
> @@ -1,5 +1,6 @@
> -/*
> - * Copyright 2014 Advanced Micro Devices, Inc.
> +// SPDX-License-Identifier: GPL-2.0
This code is under and MIT license.
Christian.
> +
> +/* Copyright 2014 Advanced Micro Devices, Inc.
> * All Rights Reserved.
> *
> * Permission is hereby granted, free of charge, to any person obtaining a
> @@ -315,6 +316,7 @@ struct dma_fence *amdgpu_sync_get_fence(struct amdgpu_sync *sync)
> struct hlist_node *tmp;
> struct dma_fence *f;
> int i;
> +
> hash_for_each_safe(sync->fences, i, tmp, e, node) {
>
> f = e->fence;
> @@ -392,7 +394,7 @@ void amdgpu_sync_free(struct amdgpu_sync *sync)
> {
> struct amdgpu_sync_entry *e;
> struct hlist_node *tmp;
> - unsigned i;
> + unsigned int i;
>
> hash_for_each_safe(sync->fences, i, tmp, e, node) {
> hash_del(&e->node);
prev parent reply other threads:[~2022-09-04 14:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-04 9:26 Jingyu Wang
2022-09-04 14:13 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5112955e-3f1a-be3f-a07d-afd0923ac26a@amd.com \
--to=christian.koenig@amd.com \
--cc=Felix.Kuehling@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingyuwang_vip@163.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®