From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14B7C2BE03C for ; Thu, 26 Feb 2026 12:54:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772110482; cv=none; b=dP1gT5hkS8AO/PsEOs8NOMT/rfwNvze8oBoNPvkG1fWqRuaBGB2SfUq9S4S8P/sx7dLM86NmH+5/jaeU387QqAT1w2VsrKGIV4DGBmgV/ODQ7ktEQx/H+jkdwabTpSvuauAXyur6+Rvb6/lzH15tyn6qXhfsGLwh1DXplEFEpd0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772110482; c=relaxed/simple; bh=HQzubOTu6bgb+A+DqydG2j67FuZ80aIJVlRPdIULpnM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mtNP1IB0wxo0SsfsB69Z2inH/htl+Gxps9YlXKoOeEIZeJP8cpAxtU+DdnS3BKZlyGwcAQZwlTMfSZuZp/U7A5x0GsYzEO6CN7lgSHlOCE1nCPE7IAJGYavq2t99YZUYoPecDunY6bXZMf4xa8BPk94mTqXkeUuJedGnObN2LPA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=SVHTU2Ag; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="SVHTU2Ag" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 756274E411F8 for ; Thu, 26 Feb 2026 12:54:37 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 373BD5FDEB; Thu, 26 Feb 2026 12:54:37 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 6242D10369381; Thu, 26 Feb 2026 13:54:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1772110475; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=rUvjUP6RPK05dYJVdn++D/ia/vKQAAkk+lldYj6DCEE=; b=SVHTU2AgzXl1bhnd0cVjBClOneG6D/oIIRvNLuQGvDeeRCkq8hYMGZ6kDeFPVG6fQY3/U8 IKoBbOOwDfqxlbIpkzQauWj5UiExzhkciz1+NjKaWsi6/ubQppEIccAga2L0iWlXdPMX4E Y0eXtiGFAL1GOX2ZyM5VcTLb/8NmQkH8BggVlBSIGI6+3B2wi7raz4tGYLnBRQ4BadiRqm 1W9KMTbGksN+e8M2c8KsAGK736R6iblN/nuICjtPDNvhQwwxOrNC1AU7vFsZZhMmm8moQH CnUOpfFrEEA4HY37RwvgP3H/ceJU45p9QW7jUW5GLHmLBNs/4MMtVZVipgYHPQ== From: Romain Gantois To: Arnd Bergmann , Greg Kroah-Hartman , Andi Shyti , Wolfram Sang , Linus Walleij , Felix Gu Cc: linux-kernel@vger.kernel.org, Felix Gu Subject: Re: [PATCH 2/2] misc: ti_fpc202: remove dead code in fpc202_detach_addr() Date: Thu, 26 Feb 2026 13:53:54 +0100 Message-ID: <5114639.31r3eYUQgx@fw-rgant> In-Reply-To: <20260221-fp202-v1-2-4d28cb8b28fb@gmail.com> References: <20260221-fp202-v1-0-4d28cb8b28fb@gmail.com> <20260221-fp202-v1-2-4d28cb8b28fb@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart4750018.LvFx2qVVIh"; micalg="pgp-sha512"; protocol="application/pgp-signature" X-Last-TLS-Session-Version: TLSv1.3 --nextPart4750018.LvFx2qVVIh Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8"; protected-headers="v1" From: Romain Gantois Cc: linux-kernel@vger.kernel.org, Felix Gu Date: Thu, 26 Feb 2026 13:53:54 +0100 Message-ID: <5114639.31r3eYUQgx@fw-rgant> In-Reply-To: <20260221-fp202-v1-2-4d28cb8b28fb@gmail.com> MIME-Version: 1.0 On Friday, 20 February 2026 18:20:32 CET Felix Gu wrote: > val is assigned from addr_caches, which is a u8 array. So the check will > never be true. > > Found by code review, compile pass. > > Signed-off-by: Felix Gu > --- > > drivers/misc/ti_fpc202.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/drivers/misc/ti_fpc202.c b/drivers/misc/ti_fpc202.c > index 578feefb77f1..79a029d79f7a 100644 > --- a/drivers/misc/ti_fpc202.c > +++ b/drivers/misc/ti_fpc202.c > @@ -243,23 +243,15 @@ static void fpc202_detach_addr(struct i2c_atr *atr, > u32 chan_id, u16 addr) > > { > > struct fpc202_priv *priv = i2c_atr_get_driver_data(atr); > > - int dev_num, reg_mod, val; > + int dev_num, val; > > for (dev_num = 0; dev_num < 2; dev_num++) { > > - reg_mod = FPC202_REG_MOD_DEV(chan_id, dev_num); > - > > mutex_lock(&priv->reg_dev_lock); > > val = priv->addr_caches[chan_id][dev_num]; > > mutex_unlock(&priv->reg_dev_lock); > > - if (val < 0) { > - dev_err(&priv->client->dev, "failed to read register 0x%x while > detaching address 0x%02x\n", - reg_mod, addr); > - return; > - } > - > > if (val == (addr & 0x7f)) { > > fpc202_write_dev_addr(priv, chan_id, dev_num, FPC202_REG_DEV_INVALID); > return; Reviewed-by: Romain Gantois --nextPart4750018.LvFx2qVVIh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEIcCsAScRrtr7W0x0KCYAIARzeA4FAmmgQmIACgkQKCYAIARz eA5N9w//Y39cmbYVIg3VneSQbt0O4OGzmMj2zTQJcMETlEcgV83v4tXKb1J8CxUk bKSYq+UR5F64etMlXQghOCJZyCa2HBU/g0KX1lByz3paA6yjJbC5npbEJcZeVP0J ehkxFk0ZplpFXC6+dDMFtn3jk9izQu/C60Svxih7Gpt9gKlG/3UypUIV1yWjJwhj PibZlPzfz8b3txTsz6qfjX2oCuMRb2aVM37Ngf/21ehlBpevl4nPh/kIUCDHWzxm 5eTPk8MGntR1XMHTGcw9Ro5E0h+dBLfieXxdNBRA6S6Y0VIsZY2TQuHjR7O9MFPH 6K5YwGnQJo5pgcafQPuj0z3XgG4nLZT0S0hkRV2NAWMuZCUEo3zvdxyV3fJx1GXk cmdewTdRdyzzZv3/R6d2xhSZbg2SfTbXcr0rdRflb1m1U9TZz8ptRBjMFkHvt3+V x8URW7jlXeqrJ+B2FAcVB4q2gvJjJwZ5/+WCHVXCEbxlVWUFYvYONfvhQFLNznMm 4fxRnkVqxATssWwB+waXZOlhouW4A7E72fjb6DY/RQWrOxyw4j9V/sAEefjE9kFz WMu4APiH+70KJoAucHIlhl+tIuwJ6MSd9w679iVTqwQuV87NLEsl5BeCABa/ydnl m4tauZcUVmQy1Hjp6edSZX3mxLyKu+Lt8iCWVN9hKtk38YygR0I= =/0tq -----END PGP SIGNATURE----- --nextPart4750018.LvFx2qVVIh--