mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PCI / hotplug / ACPI: Drop unused acpiphp_debug declaration
Date: Tue, 19 Nov 2013 21:52:17 +0100	[thread overview]
Message-ID: <5115264.27yxWCajFa@vostro.rjw.lan> (raw)
In-Reply-To: <CAErSpo56wWzNpkcEmkRnaGR4uk=eHrDzt2k-4PiHk9Rb=qRr-w@mail.gmail.com>

On Tuesday, November 19, 2013 10:23:57 AM Bjorn Helgaas wrote:
> On Tue, Nov 19, 2013 at 7:15 AM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> > Commit bd950799d951 (PCI: acpiphp: Convert to dynamic debug) removed users
> > of acpiphp_debug variable and the variable itself but the declaration was
> > left in the header file. Drop this unused declaration.
> >
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> 
> Rafael, if it makes sense for you to apply this, you can add my:
> 
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> 
> Otherwise I can pick it up.

Applied, thanks!

I'm going to send my next pull request tomorrow.

> > ---
> >  drivers/pci/hotplug/acpiphp.h | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/pci/hotplug/acpiphp.h b/drivers/pci/hotplug/acpiphp.h
> > index 26100f510b10..1592dbe4f904 100644
> > --- a/drivers/pci/hotplug/acpiphp.h
> > +++ b/drivers/pci/hotplug/acpiphp.h
> > @@ -176,7 +176,6 @@ u8 acpiphp_get_latch_status(struct acpiphp_slot *slot);
> >  u8 acpiphp_get_adapter_status(struct acpiphp_slot *slot);
> >
> >  /* variables */
> > -extern bool acpiphp_debug;
> >  extern bool acpiphp_disabled;
> >
> >  #endif /* _ACPIPHP_H */
> > --
> > 1.8.4.3
> >
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

      reply	other threads:[~2013-11-19 20:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-19 14:15 Mika Westerberg
2013-11-19 17:23 ` Bjorn Helgaas
2013-11-19 20:52   ` Rafael J. Wysocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5115264.27yxWCajFa@vostro.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=bhelgaas@google.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®