mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Slaby <jslaby@suse.cz>
To: Tejun Heo <tj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: compositing broken in -next (idr bug)
Date: Tue, 12 Feb 2013 22:59:58 +0100	[thread overview]
Message-ID: <511ABB5E.2090301@suse.cz> (raw)
In-Reply-To: <20130212215806.GB9057@htj.dyndns.org>

On 02/12/2013 10:58 PM, Tejun Heo wrote:
> Hello, Jiri.
> 
> On Tue, Feb 12, 2013 at 10:55:37PM +0100, Jiri Slaby wrote:
>> this commit in -next causes my KDE to get stuck while starting. I see
>> only the splash screen. If I disable effects by alt-shift-f12, it continues.
>>
>> I bisected it to this commit:
>> commit 430440fce7da4ad52c2af06a04a5132e5d19faaf
>> Author: Tejun Heo <tj@kernel.org>
>> Date:   Thu Feb 7 12:31:37 2013 +1100
>>
>>     drm: convert to idr_alloc()
>>
>>
>> More concretely to the change in drm_gem_flink_ioctl. If I revert solely
>> that one, it works again. Maybe I'm blind, but I do not see why...
>>
>> Well I see a bug in there, but that is not the root cause -- there is a
>> missing call to idr_preload_end. Of course, that one only leaves
>> preemption disabled forever.
> 
> Fix for this bug is already queued in -mm.
> 
>   http://article.gmane.org/gmane.linux.kernel/1439101/raw
> 
> But you're saying that adding the missing idr_preload_end() doesn't
> make the problem go away, right?

Yeah, right. I had to revert the whole hunk...

-- 
js
suse labs

  reply	other threads:[~2013-02-12 22:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-12 21:55 Jiri Slaby
2013-02-12 21:58 ` Tejun Heo
2013-02-12 21:59   ` Jiri Slaby [this message]
2013-02-12 22:03 ` Jiri Slaby
2013-02-12 22:08   ` Jiri Slaby
2013-02-12 22:13     ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=511ABB5E.2090301@suse.cz \
    --to=jslaby@suse.cz \
    --cc=airlied@linux.ie \
    --cc=akpm@linux-foundation.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®