From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751375Ab3BRLDW (ORCPT ); Mon, 18 Feb 2013 06:03:22 -0500 Received: from h1446028.stratoserver.net ([85.214.92.142]:35400 "EHLO mail.ahsoftware.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750840Ab3BRLDV (ORCPT ); Mon, 18 Feb 2013 06:03:21 -0500 Message-ID: <51220A68.9030608@ahsoftware.de> Date: Mon, 18 Feb 2013 12:03:04 +0100 From: Alexander Holler User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Mika Westerberg CC: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org, srinivas.pandruvada@intel.com Subject: Re: [PATCH 3/3] HID: sensor-hub: don't limit the driver only to USB bus References: <1360578679-7029-1-git-send-email-mika.westerberg@linux.intel.com> <1360578679-7029-3-git-send-email-mika.westerberg@linux.intel.com> In-Reply-To: <1360578679-7029-3-git-send-email-mika.westerberg@linux.intel.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 11.02.2013 11:31, schrieb Mika Westerberg: > We now have two transport mediums: USB and I2C, where sensor hubs can > exists. So instead of constraining the driver to only these two we let it > to match any HID bus as long as the group is HID_GROUP_SENSOR_HUB. > > Signed-off-by: Mika Westerberg > --- > drivers/hid/hid-sensor-hub.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c > index 2643bce9..c01f10d 100644 > --- a/drivers/hid/hid-sensor-hub.c > +++ b/drivers/hid/hid-sensor-hub.c > @@ -603,7 +603,8 @@ static void sensor_hub_remove(struct hid_device *hdev) > } > > static const struct hid_device_id sensor_hub_devices[] = { > - { HID_DEVICE(BUS_USB, HID_GROUP_SENSOR_HUB, HID_ANY_ID, HID_ANY_ID) }, > + { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, HID_ANY_ID, > + HID_ANY_ID) }, > { } > }; > MODULE_DEVICE_TABLE(hid, sensor_hub_devices); > Hmm, what happens with Bluetooth sensor-hubs? Is the driver now able to handle them too? Regards, Alexander