From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4D00C4320E for ; Mon, 30 Aug 2021 12:45:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB8D360F23 for ; Mon, 30 Aug 2021 12:45:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236687AbhH3MqX (ORCPT ); Mon, 30 Aug 2021 08:46:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:41306 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229957AbhH3MqV (ORCPT ); Mon, 30 Aug 2021 08:46:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630327528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TAcAP/xH/JBVD6nQSnDkpommozbj10qHdY7UHUiU8Q4=; b=Afd/lYWtZ3w0scwAV4ik2N22v4AZukt0cyArEOmaCZu4xuhpWhz1BLhxMFRCKI/1bznrWA oqgGT+0Y4LFaUYiFZHVa5ABopOYeIX62eq6hb/6IXtDlVrzHhdhKF9gKE9RP4nprJq3Cka FYRyqHDB3+OdH5rVkQFHwlT9AygCTAY= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-192-jz-84i6QMW-wRYb8Yqb3Tw-1; Mon, 30 Aug 2021 08:45:26 -0400 X-MC-Unique: jz-84i6QMW-wRYb8Yqb3Tw-1 Received: by mail-wr1-f70.google.com with SMTP id h14-20020a056000000e00b001575b00eb08so3262085wrx.13 for ; Mon, 30 Aug 2021 05:45:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=TAcAP/xH/JBVD6nQSnDkpommozbj10qHdY7UHUiU8Q4=; b=I8AspONtkHm0nlBEa3IivyBhfUUKh3HjPCn5d0DTzni0N8Xkq0GA25eW4ao6y+eYRP +gzHLgVL+CA32MJLhqtx2YPbtH01q/2BgLXuwFW7PAHHA42eKjcyfkigaHovnYhhMS3z OAgJ+B+GrACT/oQ+kF+IRxbyosz26efDjanYTHW9Jrotmx3MimA5/WLJ1aoSeP062Ujx 8pubb233oa17JwFblvcN63afvxq7eP4ZeD2vET3CQ76T5DdARcibHNI0QzTOjdzEhGpq w3w6rzRaZ3URLCwX5zVguqMOFtTvI1i8QzykSmf7XZtglvmV56jA7VqVbBuc7WDxIh5a 2DDA== X-Gm-Message-State: AOAM531TnZSPuVneKasdiP3RfJmT6JifbZbcnRnpAThC+YbtGiIVitjS sJ4lcRV3nBDEgf/qZj85GQkT+yJ4ew4DJmxT2gqjq7IbTUayMRFJQ6Cq7tEMUXXvkRFU8bMgKX6 Wyj7NHD+vcDO19l0eQtbz3Fhw X-Received: by 2002:adf:8169:: with SMTP id 96mr25984449wrm.207.1630327525627; Mon, 30 Aug 2021 05:45:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwHQFdtgqFJB12YSVQLA45kLlBZRJ0vA+TcNMyVfjbG7srYAviQMmfRkzLyeuyHfbf6Wy9baA== X-Received: by 2002:adf:8169:: with SMTP id 96mr25984430wrm.207.1630327525444; Mon, 30 Aug 2021 05:45:25 -0700 (PDT) Received: from ?IPv6:2a0c:5a80:3c08:b500:afb2:5ebc:3fd2:26de? ([2a0c:5a80:3c08:b500:afb2:5ebc:3fd2:26de]) by smtp.gmail.com with ESMTPSA id h6sm14368959wmq.5.2021.08.30.05.45.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Aug 2021 05:45:25 -0700 (PDT) Message-ID: <5124460b547a5f77a19e292bfb785aabde764189.camel@redhat.com> Subject: Re: [RFC PATCH v2 4/4] sensehat: Add device tree overlay (do not merge) From: nsaenzju@redhat.com To: Charles Mirabile , linux-kernel@vger.kernel.org Cc: Rob Herring , devicetree@vger.kernel.org, Serge Schneider , Stefan Wahren , linux-rpi-kernel@lists.infradead.org, fedora-rpi@googlegroups.com, Mwesigwa Guma , Joel Savitz Date: Mon, 30 Aug 2021 14:45:24 +0200 In-Reply-To: <20210820180801.561119-5-cmirabil@redhat.com> References: <20210820180801.561119-1-cmirabil@redhat.com> <20210820180801.561119-5-cmirabil@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Charles, On Fri, 2021-08-20 at 14:08 -0400, Charles Mirabile wrote: > This patch is an RFC. The overlay included here is suitable for the > Sense HAT but we are not sure where overlays like this should go, or if we > should even include it, because the Raspberry Pi kernel tree already > includes that device tree blob that this was based on and most > distributions for the Raspberry Pi include those blobs. > > The overlay is just in the root of the source tree since we did not know > where to put it so this patch should not be merged in this state. > > Signed-off-by: Charles Mirabile > Signed-off-by: Mwesigwa Guma > Signed-off-by: Joel Savitz > --- Once we get this merged, and since upstream doesn't yet mantain overlays, I suggest you merge this overlay in the downstream rpi kernel repo, who actively maintain them. AFAIK a number of distros use that repo as the base for their devicetrees. That said, I think providing a devicetree binding for this driver is a must for it to be merged (in yaml form). Regards, Nicolas