From: Sasha Levin <sasha.levin@oracle.com>
To: Tejun Heo <tj@kernel.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] idr: prevent NULL deref on lookups before insertions
Date: Wed, 20 Feb 2013 14:23:59 -0500 [thread overview]
Message-ID: <512522CF.1020901@oracle.com> (raw)
In-Reply-To: <CAOS58YMT3NS-8zvwx1tNQoLKM1WtKtT-YXBPi=4pAeAMi=rYeA@mail.gmail.com>
On 02/20/2013 01:45 PM, Tejun Heo wrote:
> Hello, Sasha.
>
> On Wed, Feb 20, 2013 at 10:44 AM, Sasha Levin <sasha.levin@oracle.com> wrote:
>> 'hint' will be NULL if we're looking up before adding anything
>> to the IDR.
>>
>> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
>
> Andy Shevchenko already posted fix (and free_layer() needs an update too).
Sorry about that, didn't see one on lkml so I've sent mine.
What about a patch that deals with:
[ 67.992946] ------------[ cut here ]------------
[ 67.994133] WARNING: at lib/idr.c:669 idr_find_slowpath+0x36/0x170()
[ 67.999650] Modules linked in:
[ 68.000469] Pid: 7156, comm: trinity Tainted: G W 3.8.0-next-20130220-sasha-00006-g3d6f01c-dirty #6
[ 68.005136] Call Trace:
[ 68.005719] [<ffffffff8110c96b>] warn_slowpath_common+0x8b/0xc0
[ 68.011168] [<ffffffff8110c9b5>] warn_slowpath_null+0x15/0x20
[ 68.012488] [<ffffffff81a23506>] idr_find_slowpath+0x36/0x170
[ 68.013805] [<ffffffff8113bbcf>] __lock_timer+0x12f/0x240
[ 68.015686] [<ffffffff8113baa0>] ? posix_timer_fn+0xd0/0xd0
[ 68.016946] [<ffffffff8113c64c>] sys_timer_delete+0x2c/0x180
[ 68.018478] [<ffffffff83dab0f5>] ? tracesys+0x7e/0xe6
[ 68.019647] [<ffffffff83dab158>] tracesys+0xe1/0xe6
[ 68.020941] ---[ end trace 6d02b1896fa2505b ]---
Thanks,
Sasha
next prev parent reply other threads:[~2013-02-20 19:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-20 18:44 Sasha Levin
2013-02-20 18:45 ` Tejun Heo
2013-02-20 19:23 ` Sasha Levin [this message]
2013-02-20 21:01 ` [PATCH] posix-timer: don't call idr_find() w/ negative ID Tejun Heo
2013-02-20 21:23 ` Andrew Morton
2013-02-20 21:37 ` Tejun Heo
2013-02-20 22:05 ` Andrew Morton
2013-02-20 22:08 ` Tejun Heo
2013-02-20 22:40 ` [PATCH] posix-timer: don't call idr_find() w/ out-of-range ID Tejun Heo
2013-02-20 23:01 ` Thomas Gleixner
2013-02-20 23:07 ` Tejun Heo
2013-02-20 23:11 ` Thomas Gleixner
2013-02-20 23:24 ` [PATCH UPDATED] " Tejun Heo
2013-02-20 23:35 ` [PATCH] idr: explain WARN_ON_ONCE() on negative IDs " Tejun Heo
2013-02-21 9:10 ` Thomas Gleixner
2013-02-21 16:38 ` [tip:timers/urgent] posix-timer: Don't call idr_find() with " tip-bot for Tejun Heo
2013-02-20 22:10 ` [PATCH] posix-timer: don't call idr_find() w/ negative ID Sasha Levin
2013-02-20 22:12 ` Tejun Heo
2013-02-20 22:15 ` Sasha Levin
2013-02-20 22:20 ` Tejun Heo
2013-02-20 23:09 ` Thomas Gleixner
2013-02-20 21:32 ` Sasha Levin
2013-02-20 21:38 ` Thomas Gleixner
2013-02-20 21:43 ` Tejun Heo
2013-02-20 21:47 ` Thomas Gleixner
2013-02-20 21:50 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512522CF.1020901@oracle.com \
--to=sasha.levin@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome