mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Ungerer <gerg@uclinux.org>
To: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Cc: geert@linux-m68k.org, linux-m68k@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m68k/nommu: fix build when CPU is not coldfire
Date: Thu, 21 Feb 2013 23:45:22 +1000	[thread overview]
Message-ID: <512624F2.2030004@uclinux.org> (raw)
In-Reply-To: <1361064814-9727-1-git-send-email-cascardo@holoscopio.com>

Hi Thadeu,

On 17/02/13 11:33, Thadeu Lima de Souza Cascardo wrote:
> Commit dd1cb3a7c43508c29e17836628090c0735bd3137 unified mm/init.c for both MMU
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Its good practice to include the text title of the patch along with the
commit id.


> and non-MMU m68k platforms. However, it broke when we build a non-MMU M68K
> Classic CPU kernel.
>
> This fix builds a section that came from the MMU version only when we are
> building a MMU kernel.

Looks good thanks. I will push this into the m68knommu git tree.

Regards
Greg



> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
> ---
>   arch/m68k/mm/init.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/m68k/mm/init.c b/arch/m68k/mm/init.c
> index afd8106f..519aad8 100644
> --- a/arch/m68k/mm/init.c
> +++ b/arch/m68k/mm/init.c
> @@ -188,7 +188,7 @@ void __init mem_init(void)
>   		}
>   	}
>
> -#if !defined(CONFIG_SUN3) && !defined(CONFIG_COLDFIRE)
> +#if defined(CONFIG_MMU) && !defined(CONFIG_SUN3) && !defined(CONFIG_COLDFIRE)
>   	/* insert pointer tables allocated so far into the tablelist */
>   	init_pointer_table((unsigned long)kernel_pg_dir);
>   	for (i = 0; i < PTRS_PER_PGD; i++) {
>


      reply	other threads:[~2013-02-21 13:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-17  1:33 Thadeu Lima de Souza Cascardo
2013-02-21 13:45 ` Greg Ungerer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=512624F2.2030004@uclinux.org \
    --to=gerg@uclinux.org \
    --cc=cascardo@holoscopio.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®