From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AF1F3CB2E0 for ; Wed, 20 May 2026 22:22:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779315756; cv=none; b=c5uogAOjH4a3HzjDiqIcsvpafR4OBRzbFl1YK1Gg0N+xx8+ABWbYkahnBPEPfQT+RnAZJLhv0fwd4zSE9g2/zjzD6SbC08tUxzvKiswd1ASoueX6RGTCmskR4AM85aAgIpSTFhr+YoEYrloFEpnMeX+KOUq0OPqcp89w///rO/M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779315756; c=relaxed/simple; bh=v8XIPZddn0cM1ZAYTFFDjJe4mcF8BIRTQpXVMkTIuNs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ikvjhWFpGs1J2WxIYh9LGkZ+TyUI05Roh0Oe6jZ2U/+BroE10U0wl8GaC+eCDDTf0346VgQanm+wVtKDZioX1pYb8v4UcHZvXTuv9TIMYJyLZgtEX3RLXXtOu2pFy6iFgtOyXRDANREh7wV8UIkWHVil2e8iieeEihXEqDm5AZw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Tv1qTEPa; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=jCppVe29; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Tv1qTEPa"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="jCppVe29" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779315754; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fkdba+Ei5cbofNgiigEWYwJVG7QGPYteKxTN237/DT4=; b=Tv1qTEPa7hIQ2mAfBgYWcJbCz1ysnfMOTCh9cyFrBkgM0sbv6f7rgTYF68ENNeUzo6uEef Ma01FiRGcOxXAKWX1elg+uRXn3MgI6qWxAon7bitQROc5IJq6/MrZ0ALcLJMqKyJp126ya syWxEEEiOGBsYJxomAosDkZW+27JwlM= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-70-7SuLQ4YkMQKd0_5U26WEWQ-1; Wed, 20 May 2026 18:22:33 -0400 X-MC-Unique: 7SuLQ4YkMQKd0_5U26WEWQ-1 X-Mimecast-MFC-AGG-ID: 7SuLQ4YkMQKd0_5U26WEWQ_1779315752 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-43d789cebcfso4212059f8f.1 for ; Wed, 20 May 2026 15:22:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779315752; x=1779920552; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Fkdba+Ei5cbofNgiigEWYwJVG7QGPYteKxTN237/DT4=; b=jCppVe29gFBNPgFzzfKdAXqSpWKcjzXew/EJpd64oyvVA2pksacojohpkbpG8a22Au dsBPGQ9v8stBOYsc8hKh7S23uUFRHA14vAjJld0sqR/mAHuJef2GDKiGBH1m9B2v8jQC 3PYZyqGHrV1qWuKCwcFQBkAElfeloGTAxJd7eGy9lXRtIc6R69nKrX3ANducrUvVNNjf 1KbjMd/ifyaNpm+BRbK9dbBwrp9H5RiL3bMiKZtBPEaR+J4ONYG8Hsrsxo+pFWy9i2+f rXeQ3bt21NQPEgsUmAZ4TbWcMFLBg9HWPiQAtbQd66GCZPjlvQWh0IUKUcXiqMucuvqw p+9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779315752; x=1779920552; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Fkdba+Ei5cbofNgiigEWYwJVG7QGPYteKxTN237/DT4=; b=WEJVIjASRj24JYuw860QXFMsXzJdHOiOfx4cFVDPCFnZVFDj+vkG/Wqva+RalzpBmx ny+X1UjaCYhzvCbGEz+ntDag6QddaJ+JdtETBj5IYYosDjXzzyrEJhvms8c4P3rDMvJF fJYGM1t0p/oXkBb3+5NBlaU2HEVyi/ljCkC4kanD7/bGoixMfezNdSTa13nWGR53qkjT Wxa1rDQmGjBVVjpIMB9PgXof1LXzcmwBxX1ysBpFHlhstrYdiiVU5WWsaXu53BijgeS1 InwquNxHhXrpF9lUmlUKAXxHRz99AcqMWz7i1beFpAqQ39G2CqctXg7uxcWmdpHFDu4T k3fw== X-Gm-Message-State: AOJu0Yx51NqcI0m1r1lxx02YT4ro/jPks7kvLMDta/PcDVGhSIKQUXeO tha1g1ZhzQT/s68VJ3th/ba5PwXjyj4E8uTBINZbJGbtnVIg5Ac1P87iF92gqDwvd0d+Uz8WDoX gKese4vuLvE0UhwMlLwxeDTMRA4km+kpWZTVX9cOqvO2cnuJu+wjmf8XIhAur5q6jnkYZr1/5DS tu8SSDKGQbPdBV79UTA/mrcWYVKHFWWwdX4DdxaV7Ur2c= X-Gm-Gg: Acq92OFSNhtVPkgVzvYdPFXw4eVjvi0iriovN9mUVogsETLVwaEZlL3O9rYDXDcl4MS CTOdQ/n4pwl3BRcxSiEu8iTwQUsFUYEljSeG4gY5S1SLubGz0ShrldAfc3bOLwUZGyKEP0inprV gIrZiS9NntjlPhAuwz6IAiQSaIURdwi8AlQCy8IsUp/Ecvt4qpFM149oF+THl4zKWYldTw+u+Vf mjdF9bVJr7zvUEVbfHq/vx9gnw4Dwn2D0IDwhJbqW3OTNwr/a43qlRtv7uuFBogJs+hjGCqTPZ0 /Vk39hF8cp0aZpvmXAJ+L1J+m7ss/Ir3qEUJ3tshG/fM+3DlGCdGJQTjamKxcgou5JIwKtPnhId /FOtF/O7pzNbEI4V7+X74uWBt047goIS0H862o8J1am4= X-Received: by 2002:a05:600c:6b12:b0:488:7d5b:125d with SMTP id 5b1f17b1804b1-49035f2e4f2mr2683695e9.7.1779315751964; Wed, 20 May 2026 15:22:31 -0700 (PDT) X-Received: by 2002:a05:600c:6b12:b0:488:7d5b:125d with SMTP id 5b1f17b1804b1-49035f2e4f2mr2683135e9.7.1779315751494; Wed, 20 May 2026 15:22:31 -0700 (PDT) Received: from redhat.com (IGLD-80-230-25-45.inter.net.il. [80.230.25.45]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45d9ed2ffdfsm53025915f8f.15.2026.05.20.15.22.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 15:22:31 -0700 (PDT) Date: Wed, 20 May 2026 18:22:26 -0400 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: "David Hildenbrand (Arm)" , Jason Wang , Xuan Zhuo , Eugenio =?utf-8?B?UMOpcmV6?= , Muchun Song , Oscar Salvador , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Hugh Dickins , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo , Axel Rasmussen , Yuanchu Xie , Wei Xu , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , virtualization@lists.linux.dev, linux-mm@kvack.org, Andrea Arcangeli Subject: [PATCH v8 23/37] mm: page_alloc: use aliasing checks instead of user_alloc_needs_zeroing Message-ID: <51265bb3f8374b093b91b07628d418375faacb9f.1779315441.git.mst@redhat.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Replace user_alloc_needs_zeroing() with the direct aliasing checks (cpu_dcache_is_aliasing() || cpu_icache_is_aliasing()) in the post_alloc_hook aliasing guard. user_alloc_needs_zeroing() includes a !init_on_alloc term that means "allocator didn't zero this page." But in this guard's context (!zeroed && !init && __GFP_ZERO), we already know the page is zero; init incorporates init_on_alloc via want_init_on_alloc(). The only question left is whether the cache architecture needs the data re-zeroed through a congruent mapping, which is purely cpu_dcache_is_aliasing() || cpu_icache_is_aliasing(). On non-aliasing architectures with init_on_free=true and init_on_alloc=false, this avoids a redundant re-zero of an already-zero page. Signed-off-by: Michael S. Tsirkin Assisted-by: Claude:claude-opus-4-6 --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 5158f7e23d18..4cb7e779a6c5 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1883,7 +1883,7 @@ inline void post_alloc_hook(struct page *page, unsigned int order, */ if (!zeroed && !init && (gfp_flags & __GFP_ZERO) && user_addr != USER_ADDR_NONE && - user_alloc_needs_zeroing()) + (cpu_dcache_is_aliasing() || cpu_icache_is_aliasing())) init = true; /* * If memory is still not initialized, initialize it now. -- MST