From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED83F34DB63 for ; Thu, 18 Dec 2025 15:39:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766072348; cv=none; b=GoxeIQQKO/Ft7mOWD3cgviTTG1AS0i+P62EC8MJWjZXLj1WVnEBo7cShrQTEywr6ICStlbUaSiC9wAKJfpmzTriPr/Ay4sbDNVKdJHA/RNBGT0IU/I9IVqFaSOfW0Q6U+1EWzoU9W7Znq+34SPmoYbQ8cDthMtIX525ssbfq7As= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766072348; c=relaxed/simple; bh=o6o4nMvnxBg9DJ1Ac4Nyxf56+dbeqxrZOucMENXeVXk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qtDQtBgf4FpYxsqGBn9oYDunWaoKBZWeA7OPeFLnMGuNnFxvBkyVkXSiv7zX7SrkUoOW80c18Z7RjKnvJFF/bOzdX5zM3PUkNOV+Kkr4DwMEnY6usOnQ+HoqRDKuQor3D5T3F0x/FNkiUbQzzmOOwBopSMcYc68qDdHmzrNfcXU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q/EIug8J; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q/EIug8J" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2a0b4320665so11295505ad.1 for ; Thu, 18 Dec 2025 07:39:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766072346; x=1766677146; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=O3+iFcm1O5KtApMe2VjVRzuyLblT2dx6soo5ROTKP70=; b=Q/EIug8J+EGrULJ2ypXem+6VEQYOH+7QmRPPUSA2eCASIJQBQ0S6ORFOz939QICZkv Ue/pVZLJPPXfLy5guWWD3iamyB0DZWqSnXtkFobRmYc0QCC1etNIZC9PonIdtXEXIdVF nG9Ywmg+usRNcDeMAQPhA8vxKcr+9ChqiPCtJBdp51QXYGllgx6tJwLMdgdoPjRloBoh qoZMu0Tjirf8elyt/nA7LzT6SJMHFN6YFnYWRpGifXo19FDy/I8AW/PXWt4JlsOjEwgu Op3OUeK4ykrPIv7PTSpd6miE7O/GNtLCNEol1ci3MUZDRIxvO4kOdqvAiuX56DawyJ5i lf/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766072346; x=1766677146; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O3+iFcm1O5KtApMe2VjVRzuyLblT2dx6soo5ROTKP70=; b=ZA88BJ/etCD7eq8BYUtxxw9sy9eemDM1vxyhcLgAdYU9d+t5/7TstSgsd7lQZwHZuz uqr1vlscGIFDMt2r2sd2oEiTCW+yGh7A9MvYKI81nWHjwd1nG2UUZzWrOgv/iN09UPtZ AxIc6J4YWZFVnyuPbpOpv4n/2ffIt7x5Zvsrn6Jc3VdOSPNq7onesVamGGML4EguErIX 2vhZtG0PFWQxVkxCokM/EXhKMM4AYpeTBTcAs+BlRaI/dMYNOeNXWkAV3zDga71wIEgv ytiL3dJ32nuR9Q51r/Pye0lqaVykHuTqU9qjcGf+rix9JbGy0bh7HzomHpdMx3vFe/rx bVjQ== X-Forwarded-Encrypted: i=1; AJvYcCXsuFXdGKGayo1W1CNJpfszvxbhXgh81L+T4dKcSVRlXlpr2FLCTT11UPOV7RXmTGSFAsQKTZVjQz8KX8I=@vger.kernel.org X-Gm-Message-State: AOJu0YyNSmX4R1V9pWMZE5CkeDmx0vbuqHdA32dqRb5GxLvfGzdB3C19 LnTlZpv49BosA+LyNobqi4pMccV0iyUdQYQv9YoanLzEdRqefFzwnLEcOawVFw== X-Gm-Gg: AY/fxX4Wqfzr8+DYj4LcmMPFGoZGwP+5wocT+Tfbb0x/tHr+rlOLU2Orteed2Ka0qFx rzj0DKcWhm4ZOyTbP2JQOfnkWUEp0RuGEx18tMugY21dUfzD1MyIYOYgACef3fa8hrHiFWzfueV mXO1jqzJ/AgPH3ycrc3gdmifeuEh0j7bFy0QcbZiVYmD7j4ab3jALwBr72/GPKD1kfJO7dI79Eu ENnrW2sRtY+bm6eKFYnZ9CZIYvYj7YBs/3bDpSbk77oXGPWNNLZTUzVJ4vvN3lBCFVNrYF1yEim UWH2RY+fX2ELquqQ1Klyl1wEz2nrPVAkLj2SgXK0bJ8orhJlGTusX5y7Rg7RD6EckmKQaGYR5uU iBHX4ye3oowQ4h6Q0DLvTOU0Mm9v7iaQCx/bezYr9NEMZCYner+ugFBCYlP5sMkZysUKcbIqgWg 19hG0yig7GI85KCsd/hff4X7EMf1t/mSzzfHq04kM9WxLXNhPqXxh16nRx5dNQ X-Google-Smtp-Source: AGHT+IGmxtmhpTIw96vEcqdJYRmgmL+V4YpucvYno3XXiqSb5eQwr35wT1A6FVud8nIqqh+FgSelIA== X-Received: by 2002:a17:902:cf03:b0:2a0:bb05:df4f with SMTP id d9443c01a7336-2a0bb05e314mr155335085ad.44.1766072346150; Thu, 18 Dec 2025 07:39:06 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2d1612735sm29562065ad.58.2025.12.18.07.39.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Dec 2025 07:39:05 -0800 (PST) Sender: Guenter Roeck Message-ID: <51271dc7-080e-4af6-ba00-9d5b2cd0871f@roeck-us.net> Date: Thu, 18 Dec 2025 07:39:03 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/page_alloc: Report 1 as zone_batchsize for !CONFIG_MMU To: Daniel Palmer , Joshua Hahn Cc: Andrew Morton , Brendan Jackman , Johannes Weiner , Michal Hocko , Suren Baghdasaryan , Vlastimil Babka , Zi Yan , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel-team@meta.com References: <20251218083200.2435789-1-joshua.hahnjy@gmail.com> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/18/25 04:30, Daniel Palmer wrote: > Hi Joshua, > > On Thu, 18 Dec 2025 at 17:32, Joshua Hahn wrote: >> >> Commit 2783088ef24e ("mm/page_alloc: prevent reporting pcp->batch = 0") >> moved the error handling (0-handling) of zone_batchsize from its >> callers to inside the function. However, the commit left out the error >> handling for the NOMMU case, leading to deadlocks on NOMMU systems. >> >> For NOMMU systems, return 1 instead of 0 for zone_batchsize, which restores >> the previous deadlock-free behavior. > > Tested this on my 68000 setup, filled the memory to cause an OOM and I > got OOM instead of deadlock as expected. > > Tested-by: Daniel Palmer > > FWIW There was a BoF about NOMMU at LPC last week and I did mention to > the people presenting that seem to be using NOMMU in real world > applications that NOMMU was broken in mainline. I hoped they would > have chimed in on this.. > Unrelated to this problem, but I gave up testing NOMMU for arm and xtensa because it was too difficult to maintain the toolchains for it. Guenter