From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757430Ab3BVVF5 (ORCPT ); Fri, 22 Feb 2013 16:05:57 -0500 Received: from mail-pb0-f41.google.com ([209.85.160.41]:62635 "EHLO mail-pb0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756789Ab3BVVFz (ORCPT ); Fri, 22 Feb 2013 16:05:55 -0500 Message-ID: <5127DDAF.2000403@linaro.org> Date: Fri, 22 Feb 2013 13:05:51 -0800 From: John Stultz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: Prarit Bhargava CC: linux-kernel@vger.kernel.org, Thomas Gleixner , x86@kernel.org, Matt Fleming , David Vrabel , Andrew Morton , Andi Kleen , linux-efi@vger.kernel.org, Alessandro Zummo Subject: Re: [RFE PATCH 2/2] rtc, add write functionality to sysfs References: <1360861375-24131-1-git-send-email-prarit@redhat.com> <1360861375-24131-3-git-send-email-prarit@redhat.com> <5127D884.6020701@linaro.org> <5127DB2B.3030700@redhat.com> In-Reply-To: <5127DB2B.3030700@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/22/2013 12:55 PM, Prarit Bhargava wrote: > > On 02/22/2013 03:43 PM, John Stultz wrote: >> On 02/14/2013 09:02 AM, Prarit Bhargava wrote: >>> /sys/class/rtc/rtcX/date and /sys/class/rtc/rtcX/time currently have >>> read-only access. This patch introduces write functionality which will >>> set the rtc time. >>> >>> Usage: echo YYYY-MM-DD > /sys/class/rtc/rtcX/date >>> echo HH:MM:SS > /sys/class/rtc/rtcX/time >> Why do we want to add a new interface here? > John, > > I'm not adding a new interface. The current date/time interface only handles > read and I'm introducing write. > Right, but what benefit does that provide? (I'm not saying there isn't any, its just not clear from your patch why this is a good thing.) Also CC'ing Alessandro for his input. thanks -john