From: Stephen Warren <swarren@wwwdotorg.org>
To: Rob Landley <rob@landley.net>
Cc: Hiroshi Doyu <hdoyu@nvidia.com>,
linux-tegra@vger.kernel.org, pdeschrijver@nvidia.com,
pgaikwad@nvidia.com, Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Russell King <linux@arm.linux.org.uk>,
Simon Glass <sjg@chromium.org>,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [v3 0/6] ARM: tegra: convert device tree files to use CLK defines
Date: Sat, 23 Feb 2013 16:52:56 -0700 [thread overview]
Message-ID: <51295658.7030105@wwwdotorg.org> (raw)
In-Reply-To: <1361649074.11282.12@driftwood>
On 02/23/2013 12:51 PM, Rob Landley wrote:
> On 02/19/2013 11:10:16 AM, Stephen Warren wrote:
>> On 02/17/2013 03:05 PM, Rob Landley wrote:
>> > On 02/15/2013 02:43:11 AM, Hiroshi Doyu wrote:
>> >> Hi,
>> >>
>> >> With new dtc+cpp feature, we could get rid of magic numbers in dts*
>> >> files. This patch replaces CLK IDs.
>> >>
>> >> We also plan to share those DT header files with kernel source
>> >> later[1].
>> > ...
>> >> [1]
>> >>
>> http://lists.infradead.org/pipermail/linux-arm-kernel/2013-February/149804.html
>>
>> >>
>> >
>> > This really smells like documentation should be updated, probably
>> > booting-without-of.txt or similar. Alas, I'm not capable of writing
>> such
>> > an update...
>>
>> I'm not sure what documentation would be updated nor why. Can you
>> describe that?
>
> "When writing new device tree files, please do not include magic
> numbers. Here's how to avoid them."
>
> Does something in Documentation already say this somewhere?
This seems rather basic and not worth documenting. The technique is
identical to the use of header files in C/assembly/... code. I suppose
if we document that, then there would be an argument for documenting this.
next prev parent reply other threads:[~2013-02-23 23:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 8:43 Hiroshi Doyu
2013-02-15 8:43 ` [v3 1/6] ARM: tegra20: create a DT header defining CLK IDs Hiroshi Doyu
2013-02-15 8:43 ` [v3 2/6] ARM: tegra20: convert device tree files to use CLK defines Hiroshi Doyu
2013-02-15 16:41 ` Stephen Warren
2013-02-15 8:43 ` [v3 3/6] ARM: tegra30: create a DT header defining CLK IDs Hiroshi Doyu
2013-02-15 8:43 ` [v3 4/6] ARM: tegra30: convert device tree files to use CLK defines Hiroshi Doyu
2013-02-15 8:43 ` [v3 5/6] ARM: tegra114: create a DT header defining CLK IDs Hiroshi Doyu
2013-02-15 16:43 ` Stephen Warren
2013-02-15 8:43 ` [v3 6/6] ARM: tegra114: convert device tree files to use CLK defines Hiroshi Doyu
2013-02-17 22:05 ` [v3 0/6] ARM: tegra: " Rob Landley
2013-02-19 17:10 ` Stephen Warren
2013-02-23 19:51 ` Rob Landley
2013-02-23 23:52 ` Stephen Warren [this message]
2013-02-17 22:20 ` Simon Glass
2013-02-19 17:08 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51295658.7030105@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=hdoyu@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=sjg@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®