From: Joe Perches <joe@perches.com>
To: Guenter Roeck <groeck@google.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Stephen Boyd <swboyd@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Julius Werner <jwerner@chromium.org>,
kernel-janitors@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC] MAINTAINERS: include GOOGLE FIRMWARE entry
Date: Sun, 08 Mar 2020 15:54:47 -0700 [thread overview]
Message-ID: <5129f7dbd8506cc9fd5a8f76dc993d789566af6c.camel@perches.com> (raw)
In-Reply-To: <CABXOdTcrxoBCz24Ap=YJYZnr+oLAmaR10xZ9ar2mYbE1=RAoug@mail.gmail.com>
On Sun, 2020-03-08 at 15:32 -0700, Guenter Roeck wrote:
> On Sun, Mar 8, 2020 at 12:51 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> > All files in drivers/firmware/google/ are identified as part of THE REST
> > according to MAINTAINERS, but they are really maintained by others.
[]
> > diff --git a/MAINTAINERS b/MAINTAINERS
[]
> > @@ -7111,6 +7111,14 @@ S: Supported
> > F: Documentation/networking/device_drivers/google/gve.rst
> > F: drivers/net/ethernet/google
> >
> > +GOOGLE FIRMWARE
> > +M: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > +M: Stephen Boyd <swboyd@chromium.org>
> > +R: Guenter Roeck <groeck@chromium.org>
> > +R: Julius Werner <jwerner@chromium.org>
> > +S: Maintained
> > +F: drivers/firmware/google/
> > +
>
> FWIW, I would not mind stepping up as maintainer if needed, but I
> think we should strongly discourage this kind of auto-assignment of
> maintainers and/or reviewers.
Auto assignment should definitely _not_ be done.
This is an RFC proposal though.
Sometimes it's better to not produce an RFC as
a patch, but maybe just show a proposed section
and ask if is appropriate may be a better style
going forward.
Maybe just emailing Greg, Stephen, Guenter and
Julius (cc'ing LKML) asking something like the
below would be better:
----------------------------------------------------
Hey all.
Files in drivers/firmware/google/ do not seem to
have a listed MAINTAINER.
Would a section entry in MAINTAINERS like this be
appropriate?
GOOGLE FIRMWARE
M: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
M: Stephen Boyd <swboyd@chromium.org>
R: Guenter Roeck <groeck@chromium.org>
R: Julius Werner <jwerner@chromium.org>
S: Maintained
F: drivers/firmware/google/
Is there a git tree somewhere that should be added?
What would be the
status of this proposed section?
Does someone really look after it at
all?
next prev parent reply other threads:[~2020-03-08 22:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-08 19:51 Lukas Bulwahn
2020-03-08 19:57 ` Greg Kroah-Hartman
2020-03-08 20:13 ` Joe Perches
2020-03-08 22:32 ` Guenter Roeck
2020-03-08 22:54 ` Joe Perches [this message]
2020-03-09 6:32 ` Lukas Bulwahn
2020-03-09 7:05 ` Greg Kroah-Hartman
2020-03-09 21:03 ` Lukas Bulwahn
2020-03-09 23:12 ` Joe Perches
2020-03-10 6:48 ` Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5129f7dbd8506cc9fd5a8f76dc993d789566af6c.camel@perches.com \
--to=joe@perches.com \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=groeck@google.com \
--cc=jwerner@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®