From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758221Ab3B0Jt4 (ORCPT ); Wed, 27 Feb 2013 04:49:56 -0500 Received: from nat28.tlf.novell.com ([130.57.49.28]:45362 "EHLO nat28.tlf.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751196Ab3B0Jtz convert rfc822-to-8bit (ORCPT ); Wed, 27 Feb 2013 04:49:55 -0500 Message-Id: <512DE4CF02000078000C15FE@nat28.tlf.novell.com> X-Mailer: Novell GroupWise Internet Agent 12.0.1 Date: Wed, 27 Feb 2013 09:49:51 +0000 From: "Jan Beulich" To: "Chen Gang" , Cc: , , "xen-devel" , , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] drivers/block/xen-blkback: preq.dev is used without initialized References: <512D90F2.9070200@asianux.com> In-Reply-To: <512D90F2.9070200@asianux.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> On 27.02.13 at 05:52, Chen Gang wrote: > if call xen_vbd_translate failed, the preq.dev will be not initialized. > so use blkif->vbd.pdevice instead (still better to print relative info). > > Signed-off-by: Chen Gang Acked-by: Jan Beulich > --- > drivers/block/xen-blkback/blkback.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/block/xen-blkback/blkback.c > b/drivers/block/xen-blkback/blkback.c > index de1f319..6d1cc3d 100644 > --- a/drivers/block/xen-blkback/blkback.c > +++ b/drivers/block/xen-blkback/blkback.c > @@ -904,7 +904,8 @@ static int dispatch_rw_block_io(struct xen_blkif *blkif, > pr_debug(DRV_PFX "access denied: %s of [%llu,%llu] on dev=%04x\n", > operation == READ ? "read" : "write", > preq.sector_number, > - preq.sector_number + preq.nr_sects, preq.dev); > + preq.sector_number + preq.nr_sects, > + blkif->vbd.pdevice); > goto fail_response; > } > > -- > 1.7.7.6