From: "Jan Beulich" <JBeulich@suse.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: "Chen Gang" <gang.chen@asianux.com>,
"Stefano Stabellini" <Stefano.Stabellini@eu.citrix.com>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
"dgdegra@tycho.nsa.gov" <dgdegra@tycho.nsa.gov>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/block/xen-blkback: preq.dev is used without initialized
Date: Wed, 27 Feb 2013 10:03:43 +0000 [thread overview]
Message-ID: <512DE80F02000078000C1650@nat28.tlf.novell.com> (raw)
In-Reply-To: <512DD6DA.5010706@citrix.com>
>>> On 27.02.13 at 10:50, Roger Pau Monné<roger.pau@citrix.com> wrote:
> On 27/02/13 05:52, Chen Gang wrote:
>>
>> if call xen_vbd_translate failed, the preq.dev will be not initialized.
>> so use blkif->vbd.pdevice instead (still better to print relative info).
>
> preq.dev is initialized a a couple of lines prior to calling
> xen_vbd_translate:
>
> preq.dev = req->u.rw.handle;
Not anymore after 01c681d4c70d64cb72142a2823f27c4146a02e63
(in Konrad's tree).
Jan
next prev parent reply other threads:[~2013-02-27 10:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 4:52 Chen Gang
2013-02-27 9:49 ` Jan Beulich
2013-02-27 9:50 ` Roger Pau Monné
2013-02-27 10:03 ` Jan Beulich [this message]
2013-02-27 9:57 ` Jan Beulich
2013-02-27 10:38 ` Chen Gang
2013-02-27 10:45 ` Jan Beulich
2013-02-27 15:40 ` Konrad Rzeszutek Wilk
2013-02-28 1:20 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512DE80F02000078000C1650@nat28.tlf.novell.com \
--to=jbeulich@suse.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=gang.chen@asianux.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®