From: "Jan Beulich" <JBeulich@suse.com>
To: "Roger Pau Monne" <roger.pau@citrix.com>
Cc: <xen-devel@lists.xen.org>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH RFC 09/12] xen-blkback: move pending handles list from blkbk to pending_req
Date: Thu, 28 Feb 2013 11:07:25 +0000 [thread overview]
Message-ID: <512F487D02000078000C1E30@nat28.tlf.novell.com> (raw)
In-Reply-To: <1362047335-26402-10-git-send-email-roger.pau@citrix.com>
>>> On 28.02.13 at 11:28, Roger Pau Monne <roger.pau@citrix.com> wrote:
> Moving grant ref handles from blkbk to pending_req will allow us to
> get rid of the shared blkbk structure.
At the expense of (slightly?) higher memory requirements?
> --- a/drivers/block/xen-blkback/blkback.c
> +++ b/drivers/block/xen-blkback/blkback.c
> @@ -136,6 +136,7 @@ struct pending_req {
> struct list_head free_list;
> struct persistent_gnt *persistent_gnts[BLKIF_MAX_SEGMENTS_PER_REQUEST];
> struct page *pages[BLKIF_MAX_SEGMENTS_PER_REQUEST];
> + grant_handle_t grant_handles[BLKIF_MAX_SEGMENTS_PER_REQUEST];
Adding yet another array here makes it even more desirable to
switch from multiple arrays to a singly array of a structure, thus
improving locality of the memory accesses involved in processing
an individual segment.
Jan
next prev parent reply other threads:[~2013-02-28 11:07 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 10:28 [PATCH RFC 00/12] xen-block: indirect descriptors Roger Pau Monne
2013-02-28 10:28 ` [PATCH RFC 01/12] xen-blkback: don't store dev_bus_addr Roger Pau Monne
2013-02-28 10:58 ` [Xen-devel] " Jan Beulich
2013-03-04 17:19 ` Roger Pau Monné
2013-03-05 8:06 ` Jan Beulich
2013-03-05 17:02 ` Roger Pau Monné
2013-02-28 10:28 ` [PATCH RFC 02/12] xen-blkback: fix foreach_grant_safe to handle empty lists Roger Pau Monne
2013-02-28 10:28 ` [PATCH RFC 03/12] xen-blkfront: switch from llist to list Roger Pau Monne
2013-02-28 10:28 ` [PATCH RFC 04/12] xen-blkfront: pre-allocate pages for requests Roger Pau Monne
2013-03-04 19:39 ` Konrad Rzeszutek Wilk
2013-03-05 11:04 ` Roger Pau Monné
2013-03-05 14:18 ` Konrad Rzeszutek Wilk
2013-03-05 16:30 ` Roger Pau Monné
2013-03-05 21:53 ` Konrad Rzeszutek Wilk
2013-03-06 9:17 ` Roger Pau Monné
2013-02-28 10:28 ` [PATCH RFC 05/12] xen-blkfront: remove frame list from blk_shadow Roger Pau Monne
2013-02-28 10:28 ` [PATCH RFC 06/12] xen-blkback: implement LRU mechanism for persistent grants Roger Pau Monne
2013-03-04 20:10 ` Konrad Rzeszutek Wilk
2013-03-05 18:10 ` Roger Pau Monné
2013-03-05 21:49 ` Konrad Rzeszutek Wilk
2013-03-18 17:00 ` Roger Pau Monné
2013-02-28 10:28 ` [PATCH RFC 07/12] xen-blkback: print stats about " Roger Pau Monne
2013-02-28 10:28 ` [PATCH RFC 08/12] xen-blkback: use balloon pages for all mappings Roger Pau Monne
2013-03-04 20:22 ` Konrad Rzeszutek Wilk
2013-03-26 17:30 ` Roger Pau Monné
2013-03-26 17:48 ` Roger Pau Monné
2013-02-28 10:28 ` [PATCH RFC 09/12] xen-blkback: move pending handles list from blkbk to pending_req Roger Pau Monne
2013-02-28 11:07 ` Jan Beulich [this message]
2013-02-28 10:28 ` [PATCH RFC 10/12] xen-blkback: make the queue of free requests per backend Roger Pau Monne
2013-02-28 11:08 ` [Xen-devel] " Jan Beulich
2013-02-28 10:28 ` [PATCH RFC 11/12] xen-blkback: expand map/unmap functions Roger Pau Monne
2013-02-28 10:28 ` [PATCH RFC 12/12] xen-block: implement indirect descriptors Roger Pau Monne
2013-02-28 11:19 ` [Xen-devel] " Jan Beulich
2013-02-28 12:00 ` Roger Pau Monné
2013-02-28 13:28 ` Jan Beulich
2013-03-04 20:44 ` Konrad Rzeszutek Wilk
2013-03-05 8:11 ` Jan Beulich
2013-03-05 14:16 ` Konrad Rzeszutek Wilk
2013-03-05 17:00 ` Roger Pau Monné
2013-03-05 21:45 ` Konrad Rzeszutek Wilk
2013-03-04 20:41 ` Konrad Rzeszutek Wilk
2013-03-05 17:07 ` Roger Pau Monné
2013-03-05 21:46 ` Konrad Rzeszutek Wilk
2013-03-08 17:07 ` Roger Pau Monné
2013-03-22 1:10 ` Konrad Rzeszutek Wilk
2013-03-18 17:06 ` Roger Pau Monné
2013-03-19 14:38 ` Konrad Rzeszutek Wilk
2013-02-28 10:49 ` [Xen-devel] [PATCH RFC 00/12] xen-block: " Jan Beulich
2013-02-28 11:25 ` Roger Pau Monné
2013-02-28 11:35 ` Jan Beulich
2013-02-28 11:44 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512F487D02000078000C1E30@nat28.tlf.novell.com \
--to=jbeulich@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®