From: Cezary Rojewski <cezary.rojewski@intel.com>
To: <phucduc.bui@gmail.com>
Cc: Baojun Xu <baojun.xu@ti.com>, Sen Wang <sen@ti.com>,
Steven Eckhoff <steven.eckhoff.opensource@gmail.com>,
Srinivas Kandagatla <srini@kernel.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Linus Walleij <linusw@kernel.org>, <u.kleine-koenig@baylibre.com>,
Thorsten Blum <thorsten.blum@linux.dev>,
Kees Cook <kees@kernel.org>, Chen Ni <nichen@iscas.ac.cn>,
Bartosz Golaszewski <brgl@kernel.org>,
Shengjiu Wang <shengjiu.wang@nxp.com>,
Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>,
Pengpeng Hou <pengpeng@iscas.ac.cn>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
<patches@opensource.cirrus.com>, <linux-kernel@vger.kernel.org>,
<linux-sound@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Lars-Peter Clausen <lars@metafoo.de>, <nuno.sa@analog.com>,
Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>
Subject: Re: [PATCH v2 04/26] ASoC: codecs: tas2781: Use guard() for mutex locks
Date: Mon, 27 Jul 2026 13:06:42 +0200 [thread overview]
Message-ID: <512ae60e-abbe-4d5d-8106-8b4020c7a2e1@intel.com> (raw)
In-Reply-To: <20260727094046.23001-5-phucduc.bui@gmail.com>
On 7/27/2026 11:40 AM, phucduc.bui@gmail.com wrote:
> @@ -1766,12 +1762,10 @@ static int tasdevice_dapm_event(struct snd_soc_dapm_widget *w,
> int state = 0;
>
> /* Codec Lock Hold */
> - mutex_lock(&tas_priv->codec_lock);
> + guard(mutex)(&tas_priv->codec_lock);
> if (event == SND_SOC_DAPM_PRE_PMD)
> state = 1;
> tasdevice_tuning_switch(tas_priv, state);
> - /* Codec Lock Release*/
If you dropped one comment, you might as well drop the "Hold" one too.
TBH, these were redundant to begin with.
> - mutex_unlock(&tas_priv->codec_lock);
>
> return 0;
> }
next prev parent reply other threads:[~2026-07-27 11:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 9:40 [PATCH v2 00/26] ASoC: codecs: Use guard() for mutex & spin locks - part 3 phucduc.bui
2026-07-27 9:40 ` [PATCH v2 01/26] ASoC: codecs: sigmadsp: Use guard() for mutex locks phucduc.bui
2026-08-03 13:13 ` Nuno Sá
2026-07-27 9:40 ` [PATCH v2 02/26] ASoC: codecs: sta350: " phucduc.bui
2026-07-27 9:40 ` [PATCH v2 03/26] ASoC: codecs: sta32x: " phucduc.bui
2026-07-27 9:40 ` [PATCH v2 04/26] ASoC: codecs: tas2781: " phucduc.bui
2026-07-27 11:06 ` Cezary Rojewski [this message]
2026-07-28 2:08 ` Bui Duc Phuc
2026-07-27 9:40 ` [PATCH v2 05/26] ASoC: codecs: tas2783: " phucduc.bui
2026-07-27 9:40 ` [PATCH v2 06/26] ASoC: codecs: tas5805m: " phucduc.bui
2026-07-27 9:40 ` [PATCH v2 07/26] ASoC: codecs: tlv320dac33: Use guard() for mutex & spin locks phucduc.bui
2026-07-27 9:40 ` [PATCH v2 08/26] ASoC: codecs: tscs42xx: Use guard() for mutex locks phucduc.bui
2026-07-27 9:40 ` [PATCH v2 09/26] ASoC: codecs: tscs454: " phucduc.bui
2026-07-27 9:40 ` [PATCH v2 10/26] ASoC: codecs: twl6040: " phucduc.bui
2026-07-27 9:40 ` [PATCH v2 11/26] ASoC: codecs: wcd-mbhc: " phucduc.bui
2026-07-27 9:40 ` [PATCH v2 12/26] ASoC: codecs: wcd934x: " phucduc.bui
2026-07-27 9:40 ` [PATCH v2 13/26] ASoC: codecs: wcd937x: " phucduc.bui
2026-07-27 9:40 ` [PATCH v2 14/26] ASoC: codecs: wcd938x: " phucduc.bui
2026-07-27 9:40 ` [PATCH v2 15/26] ASoC: codecs: wcd939x: " phucduc.bui
2026-07-27 9:40 ` [PATCH v2 16/26] ASoC: codecs: wm0010: Use guard() for mutex & spin locks phucduc.bui
2026-07-27 9:40 ` [PATCH v2 17/26] ASoC: codecs: wm2000: Use guard() for mutex locks phucduc.bui
2026-07-27 9:40 ` [PATCH v2 18/26] ASoC: codecs: wm5102: " phucduc.bui
2026-07-27 9:40 ` [PATCH v2 19/26] ASoC: codecs: wm8731: " phucduc.bui
2026-07-27 9:40 ` [PATCH v2 20/26] ASoC: codecs: wm8903: " phucduc.bui
2026-07-27 9:40 ` [PATCH v2 21/26] ASoC: codecs: wm8958: " phucduc.bui
2026-07-27 9:40 ` [PATCH v2 22/26] ASoC: codecs: wm8962: " phucduc.bui
2026-07-27 9:40 ` [PATCH v2 23/26] ASoC: codecs: wm8994: " phucduc.bui
2026-07-27 9:40 ` [PATCH v2 24/26] ASoC: codecs: wm971x: " phucduc.bui
2026-07-27 9:50 ` Richard Fitzgerald
2026-07-27 9:40 ` [PATCH v2 25/26] ASoC: codecs: wm_adsp: " phucduc.bui
2026-07-27 9:53 ` Richard Fitzgerald
2026-07-27 9:40 ` [PATCH v2 26/26] ASoC: codecs: wsa88xx: " phucduc.bui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512ae60e-abbe-4d5d-8106-8b4020c7a2e1@intel.com \
--to=cezary.rojewski@intel.com \
--cc=baojun.xu@ti.com \
--cc=brgl@kernel.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=kees@kernel.org \
--cc=kevin-lu@ti.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=nichen@iscas.ac.cn \
--cc=nuno.sa@analog.com \
--cc=patches@opensource.cirrus.com \
--cc=pengpeng@iscas.ac.cn \
--cc=perex@perex.cz \
--cc=phucduc.bui@gmail.com \
--cc=rf@opensource.cirrus.com \
--cc=sebastian.krzyszkowiak@puri.sm \
--cc=sen@ti.com \
--cc=shenghao-ding@ti.com \
--cc=shengjiu.wang@nxp.com \
--cc=srini@kernel.org \
--cc=steven.eckhoff.opensource@gmail.com \
--cc=thorsten.blum@linux.dev \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®