From: "Kristen Accardi" <kristen.kml@gmail.com>
To: "Al Viro" <viro@ftp.linux.org.uk>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wrong order of kzalloc arguments
Date: Fri, 9 Feb 2007 09:48:10 -0800 [thread overview]
Message-ID: <512afbf90702090948v403b6e2fmedfb938645415928@mail.gmail.com> (raw)
In-Reply-To: <E1HFYFH-0004qI-0v@ZenIV.linux.org.uk>
On 2/9/07, Al Viro <viro@ftp.linux.org.uk> wrote:
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> drivers/acpi/bay.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/acpi/bay.c b/drivers/acpi/bay.c
> index 667fa1d..91082ce 100644
> --- a/drivers/acpi/bay.c
> +++ b/drivers/acpi/bay.c
> @@ -296,7 +296,7 @@ static int bay_add(acpi_handle handle, int id)
> /*
> * Initialize bay device structure
> */
> - new_bay = kzalloc(GFP_ATOMIC, sizeof(*new_bay));
> + new_bay = kzalloc(sizeof(*new_bay), GFP_ATOMIC);
> INIT_LIST_HEAD(&new_bay->list);
> new_bay->handle = handle;
> new_bay->name = (char *)nbuffer.pointer;
> --
> 1.5.0-rc2.GIT
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
Oops. thanks for taking the time to review and fix this.
Kristen
prev parent reply other threads:[~2007-02-09 17:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-09 16:05 Al Viro
2007-02-09 17:48 ` Kristen Accardi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512afbf90702090948v403b6e2fmedfb938645415928@mail.gmail.com \
--to=kristen.kml@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®