Re: [PATCH 07/13] dt-bindings: media: camss: Add qcom,sm8550-camss binding

[Depeng Shao <quic_depengs@quicinc.com>]

Hi Krzysztof,

On 7/10/2024 7:07 PM, Krzysztof Kozlowski wrote:

>> +
>> +description: |
> 
> Do not need '|' unless you need to preserve formatting.
> 
> This wasn't tested so I am not going to perform full review.
> 
> Look at "Re: [PATCH 1/6] media: dt-bindings: media: camss: Add
> qcom,sc7280-camss binding" - all comments apply.
> 
> ...
> 


Sure, I will follow the comments in 
https://lore.kernel.org/linux-arm-msm/087e7f29-1fa8-4bc2-bb3d-acb941432381@kernel.org/

>> +
>> +required:
>> +  - clock-names
>> +  - clocks
>> +  - compatible
> 
> Keep the same order as in "properties:'.
> 
Sure, I will update it.


>> +
>> +            reg = <0 0x0ace4000 0 0x2000>,
>> +                  <0 0x0ace6000 0 0x2000>,
>> +                  <0 0x0ace8000 0 0x2000>,
>> +                  <0 0x0acea000 0 0x2000>,
>> +                  <0 0x0acec000 0 0x2000>,
>> +                  <0 0x0acee000 0 0x2000>,
>> +                  <0 0x0acf0000 0 0x2000>,
>> +                  <0 0x0acf2000 0 0x2000>,
>> +                  <0 0x0acb7000 0 0xd00>,
>> +                  <0 0x0acb9000 0 0xd00>,
>> +                  <0 0x0acbb000 0 0xd00>,
>> +                  <0 0x0acca000 0 0xa00>,
>> +                  <0 0x0acce000 0 0xa00>,
>> +                  <0 0x0acb6000 0 0x1000>,
>> +                  <0 0x0ac62000 0 0xf000>,
>> +                  <0 0x0ac71000 0 0xf000>,
>> +                  <0 0x0ac80000 0 0xf000>,
>> +                  <0 0x0acca000 0 0x2800>,
>> +                  <0 0x0acce000 0 0x2800>;
>> +            reg-names = "csiphy0",
>> +                    "csiphy1",
>> +                    "csiphy2",
>> +                    "csiphy3",
> 
> These (and many others further) looks misaligned.
> 
Thanks for pointing out this, will fix this.

> Best regards,
> Krzysztof
> 

Thanks,
Depeng