From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23C1F35F612 for ; Thu, 26 Mar 2026 08:54:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774515299; cv=none; b=ZBuf891dLPShL/XPnl/56vN5TgUi5BiJ/lTh8olyI6pBXAET1DZTTRJXDRssbth4jnb6B3eqbVwshtWIRtqgdhN84paaRy/XoZAfSAUOw0ZIF2cUzCLi9qUdQwNpNsd6LrHN9063qd3i1JcdyoaXOKix7zVEGTVk8eZQDuoprv0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774515299; c=relaxed/simple; bh=sDMEuZ5NbvWpRTjfdc6QeJE8QGjyvgn4ez8QF19VQ0I=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=mzZN+7zGHFp1EyYJxmeKRmJO9V9xw8jB5yU0a8DMG9cO+oOvklRgOjE6fRwwFnJyrtrk1PP/c78CreLryT7M9b0bHdfTFDGVAyGe5HdTlfZCmyutPvO6WBWRv+EtSePZv1JDHiKQBnXJFUfbqdDO5qAP5RCDjDJ2K1GeZudDk4c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=o0z1S6+a; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="o0z1S6+a" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-487035181a7so4237445e9.2 for ; Thu, 26 Mar 2026 01:54:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774515295; x=1775120095; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=NPOq+t0BPIjTXIy85z0pLZNyx1Sqnvxn5kHxjGZM2Uw=; b=o0z1S6+aU93OlkOzo7sM3NMZSGxiJPty9c6uVfGVerbwntDWAYebxSBkmpLFLWMiw0 mwCcud2XkX0Qg6vp6ndNzPT/P+wcUe/jxNZsnxRXIpd7Siezh6TxU7oEwh9VaueEFh0H 2D1hIXgW1V3YfrEbS4zcmb5uD3VxENuhFD2aEhv9lti8iN3RkVV+OHhdyzkKwip3sB7b uQFQCd1a6Ujgd4biVNtE7BHKkqu8ElvOtbcNHEDGFALH8cDv//LYTyu+g187TVw91qHg Yn88dudTl3SOOJS2tAyXI+6qKuUz75zsgQO+9f7ua2x7hS/WflKKMKcWysJXqLy/l4Ph JqzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774515295; x=1775120095; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NPOq+t0BPIjTXIy85z0pLZNyx1Sqnvxn5kHxjGZM2Uw=; b=jREi00yuA1ompXeiB640stxqk2E40qwB/5lcCE9TvZN2DAoSBi+C+3bF/yE24VdTcd 2YvMidOq6VuHJfTtOY8rN+2mfGKjP98nXeIVWdi3ZtP2VnBuDokdJQEKrvaOlIK0QDtD IbvVoRioYkjsdJiAygPDiTTVMMawtwzqhuUrijMggig6ZLV5OImy9Dv/e1c0HBJk3w7Q 1nXkcvPJEyOLQ5ZB65ZBQnZN8DoBONp/b/77RNNupKsC9mvIUMF91pqV2hoDizFAfEIb CggR2joKONvrk+2YXbpps9CGE8WZepsZvSt+0rO1HPPLyDWmdzBprVupUheynixOP9zO OxQw== X-Forwarded-Encrypted: i=1; AJvYcCV8jz3/RyAa5we/9n4Nd7kHum2l4nmAk8NEXb+AEbA8FQPE/6oJr40QRsohw6ylsVCbyAub1OYhQHV9YoI=@vger.kernel.org X-Gm-Message-State: AOJu0YxdM5KHsad4AObe33vuWI/euasMPR3kflFk9p3H/UN3ZcNnW6+v 979ZIlRFMCh2MsvAH0+vrbwS/cTuh+wLNoplhVubux4FceEzhrzGcrehfClkleLib+o= X-Gm-Gg: ATEYQzwXSoi4BgnftjkD2nI+IdfnrEoUy8+yN38cXcN+H8hTOxcijfklhP8pkSonjW9 jiZ6rvH+X9HAuautJmWe1yz0cP11OAS8IsG0NOp4U4JXQeNPlleHXwTjXUcukA38E74+P7lyonT eNlg8NGfE3gMHJUGnGlKhYXNL6nnSbq97OYva+x00j9b9Onp478G4Jlb25fctjcosRRWe/InAne Nt3A6L2Fsp6hjIDWAGAS62dd9Cv9jPuMmeeUU2XH8WuEGQG5hR9tY7IcI1R0zNYZh8Ob9zaI9Cr QMvswA1mrOXQmHqpIFl0U6xo8lJnbrc6Tdpflrs6mcs7hIq49L1jXFliQeJLtz/rvA31HubKBKZ scM46CMSTOeysMpxUT77Nahchwx1dIk3lkaIb5UE7adx4yHuVX33dhQjEUaKlYgN/2JSGaRXM8N hzfnetMKrcNouOot5oiBIP1NQfLdWYSh1vqvIIs7cPOmhMyg7ommbWctI0a2GQiJVsCGZPSiupp n7ZbyA= X-Received: by 2002:a05:600c:3e1a:b0:486:af22:4a2a with SMTP id 5b1f17b1804b1-48715fbabedmr88067005e9.7.1774515295443; Thu, 26 Mar 2026 01:54:55 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:8431:f88b:714d:f78d? ([2a01:e0a:106d:1080:8431:f88b:714d:f78d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48720901b90sm10376515e9.17.2026.03.26.01.54.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Mar 2026 01:54:55 -0700 (PDT) Message-ID: <512d95b5-5348-4c7c-961c-b6ca1431cee4@linaro.org> Date: Thu, 26 Mar 2026 09:54:54 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v4 9/9] arm64: dts: amlogic: t7: khadas-vim4: Add MMC nodes To: Ronald Claveau , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ulf Hansson , Johannes Berg , van Spriel Cc: linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-wireless@vger.kernel.org References: <20260325-add-emmc-t7-vim4-v4-0-44c7b4a5e459@aliel.fr> <20260325-add-emmc-t7-vim4-v4-9-44c7b4a5e459@aliel.fr> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260325-add-emmc-t7-vim4-v4-9-44c7b4a5e459@aliel.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/25/26 10:15, Ronald Claveau wrote: > Enable and configure the three MMC controllers for the Khadas VIM4 board: > - sd_emmc_a: SDIO interface for the BCM43752 Wi-Fi module > - sd_emmc_b: SD card slot > - sd_emmc_c: eMMC storage > > Signed-off-by: Ronald Claveau > --- > .../dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts | 90 +++++++++++++++++++++- > 1 file changed, 89 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts > index 770f06b0b16c7..5a73ae081036c 100644 > --- a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts > +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts > @@ -14,7 +14,10 @@ / { > compatible = "khadas,vim4", "amlogic,a311d2", "amlogic,t7"; > > aliases { > - serial0 = &uart_a; > + serial0 = &uart_a; Spurious change > + mmc0 = &sd_emmc_c; > + mmc1 = &sd_emmc_b; > + mmc2 = &sd_emmc_a; > }; > > memory@0 { > @@ -159,6 +162,91 @@ &pwm_ab { > pinctrl-names = "default"; > }; > > +/* SDIO */ > +&sd_emmc_a { > + status = "okay"; > + pinctrl-0 = <&sdio_pins>; > + pinctrl-1 = <&sdio_clk_gate_pins>; > + pinctrl-names = "default", "clk-gate"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + bus-width = <4>; > + cap-sd-highspeed; > + sd-uhs-sdr12; > + sd-uhs-sdr25; > + sd-uhs-sdr50; > + sd-uhs-sdr104; > + cap-sdio-irq; > + max-frequency = <200000000>; > + non-removable; > + disable-wp; > + no-mmc; > + no-sd; > + > + power-domains = <&pwrc PWRC_T7_SDIO_A_ID>; > + > + keep-power-in-suspend; > + > + mmc-pwrseq = <&sdio_pwrseq>; > + > + vmmc-supply = <&vddao_3v3>; > + vqmmc-supply = <&vddao_1v8>; > + > + brcmf: wifi@1 { > + reg = <1>; > + compatible = "brcm,bcm43752-fmac", "brcm,bcm4329-fmac"; > + }; > +}; > + > +/* SD card */ > +&sd_emmc_b { > + status = "okay"; > + pinctrl-0 = <&sdcard_pins>; > + pinctrl-1 = <&sdcard_clk_gate_pins>; > + pinctrl-names = "default", "clk-gate"; > + > + bus-width = <4>; > + cap-sd-highspeed; > + sd-uhs-sdr12; > + sd-uhs-sdr25; > + sd-uhs-sdr50; > + sd-uhs-sdr104; > + max-frequency = <200000000>; > + disable-wp; > + no-sdio; > + no-mmc; > + > + power-domains = <&pwrc PWRC_T7_SDIO_B_ID>; > + > + cd-gpios = <&gpio GPIOC_6 GPIO_ACTIVE_LOW>; > + vmmc-supply = <&sd_3v3>; > + vqmmc-supply = <&vddio_c>; > +}; > + > +/* eMMC */ > +&sd_emmc_c { > + status = "okay"; > + pinctrl-0 = <&emmc_ctrl_pins>, <&emmc_data_8b_pins>, <&emmc_ds_pins>; > + pinctrl-1 = <&emmc_clk_gate_pins>; > + pinctrl-names = "default", "clk-gate"; > + > + bus-width = <8>; > + cap-mmc-highspeed; > + mmc-ddr-1_8v; > + mmc-hs200-1_8v; > + max-frequency = <200000000>; > + disable-wp; > + non-removable; > + no-sdio; > + no-sd; > + > + power-domains = <&pwrc PWRC_T7_EMMC_ID>; > + > + vmmc-supply = <&vddio_3v3>; > + vqmmc-supply = <&vddio_1v8>; > +}; > + > &uart_a { > status = "okay"; > clocks = <&xtal>, <&xtal>, <&xtal>; > With that: Reviewed-by: Neil Armstrong Thanks, Neil