From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754524AbcIUHcM (ORCPT ); Wed, 21 Sep 2016 03:32:12 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:58671 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751635AbcIUHbq (ORCPT ); Wed, 21 Sep 2016 03:31:46 -0400 Subject: Re: [PATCH 8/9] dmaengine: ti-dma-crossbar: Use enum for crossbar type To: Vinod Koul References: <20160916083324.29133-1-peter.ujfalusi@ti.com> <20160916083324.29133-9-peter.ujfalusi@ti.com> <20160921035226.GE2609@localhost> CC: , , , , , , From: Peter Ujfalusi Message-ID: <512e93da-9a25-01d5-4a71-07a48e28702d@ti.com> Date: Wed, 21 Sep 2016 10:31:13 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20160921035226.GE2609@localhost> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/21/16 06:52, Vinod Koul wrote: > On Fri, Sep 16, 2016 at 11:33:23AM +0300, Peter Ujfalusi wrote: >> Fixes compiler warning on 64bit architectures. > > Would be good to give the warning message here Let me revert this patch and patch #2 for the eDMA to get the warnings. I will repost v2 with the updated commit messages. > >> >> Signed-off-by: Peter Ujfalusi >> --- >> drivers/dma/ti-dma-crossbar.c | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/dma/ti-dma-crossbar.c b/drivers/dma/ti-dma-crossbar.c >> index e4f3bd1ae264..876e4ccaf033 100644 >> --- a/drivers/dma/ti-dma-crossbar.c >> +++ b/drivers/dma/ti-dma-crossbar.c >> @@ -16,8 +16,10 @@ >> #include >> #include >> >> -#define TI_XBAR_DRA7 0 >> -#define TI_XBAR_AM335X 1 >> +enum ti_xbar_type { >> + TI_XBAR_DRA7 = 0, >> + TI_XBAR_AM335X, >> +}; >> >> static const struct of_device_id ti_dma_xbar_match[] = { >> { >> @@ -395,7 +397,7 @@ static int ti_dra7_xbar_probe(struct platform_device *pdev) >> >> xbar->dmarouter.dev = &pdev->dev; >> xbar->dmarouter.route_free = ti_dra7_xbar_free; >> - xbar->dma_offset = (u32)match->data; >> + xbar->dma_offset = (enum ti_xbar_type)match->data; >> >> mutex_init(&xbar->mutex); >> platform_set_drvdata(pdev, xbar); >> @@ -428,7 +430,7 @@ static int ti_dma_xbar_probe(struct platform_device *pdev) >> if (unlikely(!match)) >> return -EINVAL; >> >> - switch ((u32)match->data) { >> + switch ((enum ti_xbar_type)match->data) { >> case TI_XBAR_DRA7: >> ret = ti_dra7_xbar_probe(pdev); >> break; >> -- >> 2.10.0 >> > -- Péter