From: Marc Gonzalez <marc.w.gonzalez@free.fr>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
MSM <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Can Guo <cang@codeaurora.org>,
Vivek Gautam <vivek.gautam@codeaurora.org>,
Evan Green <evgreen@chromium.org>,
Jeffrey Hugo <jhugo@codeaurora.org>
Subject: Re: [PATCH] phy: qcom: qmp: Add SDM845 PCIe QMP PHY support
Date: Fri, 22 Mar 2019 14:42:31 +0100 [thread overview]
Message-ID: <513163ea-78fe-2910-2e82-a7014bda82e8@free.fr> (raw)
In-Reply-To: <20190226065919.22218-1-bjorn.andersson@linaro.org>
On 26/02/2019 07:59, Bjorn Andersson wrote:
> @@ -1384,6 +1536,11 @@ static int qcom_qmp_phy_init(struct phy *phy)
>
> qcom_qmp_phy_configure(pcs, cfg->regs, cfg->pcs_tbl, cfg->pcs_tbl_num);
>
> + if (cfg->pcs_misc_tbl) {
> + qcom_qmp_phy_configure(pcs_misc, cfg->regs, cfg->pcs_misc_tbl,
> + cfg->pcs_misc_tbl_num);
> + }
> +
> /*
> * UFS PHY requires the deassert of software reset before serdes start.
> * For UFS PHYs that do not have software reset control bits, defer
I think it would be better to configure pcs_misc *before* pcs.
That would be closer to what downstream does (for 835 and 845 at least).
Also you don't need to test for NULL as that is already done in
qcom_qmp_phy_configure() -- and in fact even that test is redundant,
since the array is not dereferenced when count is 0.
When are you planning on sending a v2 of your PCIe series?
Regards.
next prev parent reply other threads:[~2019-03-22 13:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 6:59 Bjorn Andersson
2019-02-27 9:27 ` Marc Gonzalez
2019-02-27 18:09 ` Bjorn Andersson
2019-02-27 13:48 ` Marc Gonzalez
2019-03-22 13:42 ` Marc Gonzalez [this message]
2019-03-29 14:00 ` Marc Gonzalez
2019-03-22 15:34 ` Evan Green
2019-03-26 14:59 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513163ea-78fe-2910-2e82-a7014bda82e8@free.fr \
--to=marc.w.gonzalez@free.fr \
--cc=bjorn.andersson@linaro.org \
--cc=cang@codeaurora.org \
--cc=evgreen@chromium.org \
--cc=jhugo@codeaurora.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®